Re: Intermittent Failures in t1450-fsck (Bisected)

[Jeff King <peff@peff.net>]

On Thu, May 05, 2011 at 05:07:54PM -0400, Brian Gernhardt wrote:

> On May 5, 2011, at 4:04 PM, Brian Gernhardt wrote:
> 
> > On May 5, 2011, at 5:32 AM, Jeff King wrote:
> > 
> >> Given that the problem seems racy and intermittent, have you tried
> >> running under valgrind?
> > 
> > This is on my OS X laptop and last I knew valgrind was very buggy on OS X, so I've never tried it.  I'll install it now and see if I can get anything useful out of it.
> 
> I will note the test _reliably_ fails when run in parallel with other tests.

It might be interference from another test, though in general they
should all be in their own little sandboxes. It could just be a race
condition that gets triggered more reliably when the system is under
load.

> Under valgrind I get the following error.  I will note that attempting
> to run the full test suite with valgrind gives lots of similar errors
> in many tests.  (All conditional jump in deflate, allocated in
> write_loose_object.)

This is probably a false positive. On Linux we see these in libz because
it has some weird optimized loop that can read past the end of the
buffer (though I have usually see it in the inflate code path, not
deflate).

-Peff