git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kacper Kornet <draenog@pld-linux.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t1507: change quoting in test_did_you_mean to a more general one
Date: Fri, 6 May 2011 10:39:37 +0200	[thread overview]
Message-ID: <20110506083937.GA3719@camk.edu.pl> (raw)
In-Reply-To: <7vsjss6hmf.fsf@alter.siamese.dyndns.org>

On Thu, May 05, 2011 at 01:02:16PM -0700, Junio C Hamano wrote:
> Kacper Kornet <draenog@pld-linux.org> writes:

> > In bash and some other shells the script:

> >   x=2; unset a; echo "${a:-'$x'}"

> > prints '2'. However ksh shell prints $x. The quoting is added to
> > reproduce bash behaviour.

> What I happen to have in /usr/bin/ksh

>     $ /usr/bin/ksh --version
>       version         sh (AT&T Research) 93t+ 2009-05-01

> does not seem to have this issue.

> Whose ksh is this

It is pdksh 5.2.14 from http://www.cs.mun.ca/~michael/pdksh/

> It is broken.

You are right. It is corrected in mksh, which claims to be a successor
to pdksh. Unfortunately pdksh is used by default as /bin/sh in PLD Linux
Distribution which are use. Probably the time to think about the change
of this default.

-- 
  Kacper Kornet

      parent reply	other threads:[~2011-05-06  8:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-05 19:10 [PATCH] t1507: change quoting in test_did_you_mean to a more general one Kacper Kornet
2011-05-05 20:02 ` Junio C Hamano
2011-05-06  7:43   ` Michael J Gruber
2011-05-06  8:51     ` Kacper Kornet
2011-05-06  9:14       ` Michael J Gruber
2011-05-06 10:22     ` Johannes Sixt
2011-05-06 11:10       ` Michael J Gruber
2011-05-06 14:23       ` Junio C Hamano
2011-05-09  4:40       ` Junio C Hamano
2011-05-09  6:39         ` Johannes Sixt
2011-05-09 16:20           ` Junio C Hamano
2011-05-06  8:39   ` Kacper Kornet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110506083937.GA3719@camk.edu.pl \
    --to=draenog@pld-linux.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).