From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: conrad.irwin@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH v3 0/3] Git commit --patch (again)
Date: Tue, 10 May 2011 15:56:47 -0400 [thread overview]
Message-ID: <20110510195646.GC14456@sigill.intra.peff.net> (raw)
In-Reply-To: <7vwrhzmnxf.fsf@alter.siamese.dyndns.org>
On Mon, May 09, 2011 at 04:53:00PM -0700, Junio C Hamano wrote:
> -- >8 --
> From: Jeff King <peff@peff.net>
> Subject: [PATCH] t7501.8: feed a meaningful command
>
> The command expects "git commit --interactive <path>" to fail because you
> cannot (yet) limit "commit --interactive" with a pathspec, but even if the
> command allowed to take <path>, the test would have failed as saying just
> 7:quit would leave the index the same as the current commit, leading to an
> attempt to create an empty commit that would fail without --allow-empty.
>
> Signed-off-by: Jeff King <peff@peff.net>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Thanks. The commit message and SBO-forgery are fine by me. :)
-Peff
next prev parent reply other threads:[~2011-05-10 19:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 5:59 [PATCH v3 0/3] Git commit --patch (again) conrad.irwin
2011-05-07 5:59 ` [PATCH v3 1/3] Use a temporary index for git commit --interactive conrad.irwin
2011-05-07 6:00 ` [PATCH v3 2/3] Allow git commit --interactive with paths conrad.irwin
2011-05-07 6:00 ` [PATCH v3 3/3] Add support for -p/--patch to git-commit conrad.irwin
2011-05-07 10:46 ` Valentin Haenel
2011-05-07 17:55 ` Conrad Irwin
2011-05-07 17:58 ` [PATCH v4 " Conrad Irwin
2011-05-08 19:27 ` Junio C Hamano
2011-05-07 17:59 ` [PATCH] Add commit to list of config.singlekey commands Conrad Irwin
2011-05-07 9:49 ` [PATCH v3 0/3] Git commit --patch (again) Sverre Rabbelier
2011-05-09 14:44 ` Jeff King
2011-05-09 16:53 ` Junio C Hamano
2011-05-09 22:08 ` Jeff King
2011-05-09 23:53 ` Junio C Hamano
2011-05-09 23:56 ` Junio C Hamano
2011-05-10 20:01 ` Jeff King
2011-05-10 19:56 ` Jeff King [this message]
2011-05-10 6:42 ` Conrad Irwin
2011-05-10 19:12 ` [PATCH] Test atomic git-commit --interactive Conrad Irwin
2011-05-10 19:43 ` Jeff King
2011-05-10 21:01 ` Conrad Irwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110510195646.GC14456@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=conrad.irwin@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).