git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: "Git List" <git@vger.kernel.org>,
	"Shawn O. Pearce" <gsoc@spearce.org>,
	"SZEDER Gábor" <szeder@ira.uka.de>,
	"Stephen Boyd" <bebarino@gmail.com>
Subject: Re: [BUG] Autocompletion fails with "bash: words: bad array subscript"
Date: Tue, 10 May 2011 16:31:01 -0400	[thread overview]
Message-ID: <20110510203101.GG14456@sigill.intra.peff.net> (raw)
In-Reply-To: <BANLkTi=nOUEp_J+2dkZZp=HvER-eAdG9eg@mail.gmail.com>

On Tue, May 10, 2011 at 10:13:11PM +0200, Sverre Rabbelier wrote:

> This happens if I try use ctrl-shift-r (reverse-i-search) for the
> string `git commit -am "S`, resulting in the following:
> 
> (reverse-i-search)`git commit -am "S': git commit -am "Set new Melange
> version number to 2-0-20110501 in app.yaml.template."
> 
> If I then hit tab, I get:
> 
> $ bash: words: bad array subscriptversion number to 2-0-20110501 in
> app.yaml.template."

I can reproduce it here pretty easily.

> Hitting tab again gives:
> 
> bash: words: bad array subscript
> 
> Display all 3032 possibilities? (y or n)
> 
> I have no clue how to debug this, other than that it doesn't happen if
> I don't source ~/code/git/contrib/completion/git-completion.bash.
> 
> Anyone have any idea's?

You can try "set -x" which will show you what was executing. Of course
that will spew pages of output. So you'll want to use something like
"script", or if you're man enough, "exec 2>stderr" and then do the whole
thing blind. ;)

It looks like we set $cword too low at some point, as the problematic
code seems to be:

  + upargs+=(-v $vprev "${words[cword - 1]}")
  bash: words: bad array subscript

but I haven't figured out yet where that happens.

-Peff

  reply	other threads:[~2011-05-10 20:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-10 20:13 [BUG] Autocompletion fails with "bash: words: bad array subscript" Sverre Rabbelier
2011-05-10 20:31 ` Jeff King [this message]
2011-05-10 20:39   ` Jeff King
2011-05-10 20:47     ` Sverre Rabbelier
2011-05-10 21:01       ` Jeff King
2011-05-10 21:02         ` Sverre Rabbelier
2011-05-10 21:10           ` Jeff King
2011-05-10 22:39             ` SZEDER Gábor
2011-05-10 23:45               ` Jonathan Nieder
2011-05-11 21:09                 ` SZEDER Gábor
2011-05-10 22:14 ` [PATCH] completion: fix array indexing error after reverse history search SZEDER Gábor
2011-05-10 22:19   ` Sverre Rabbelier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110510203101.GG14456@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=bebarino@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gsoc@spearce.org \
    --cc=srabbelier@gmail.com \
    --cc=szeder@ira.uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).