From: Jeff King <peff@peff.net>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git cherry-pick --strategy=resolve segfaults if picking a root commit
Date: Thu, 12 May 2011 07:08:55 -0400 [thread overview]
Message-ID: <20110512110855.GA5240@sigill.intra.peff.net> (raw)
In-Reply-To: <20110512104558.GA22108@sigill.intra.peff.net>
On Thu, May 12, 2011 at 06:45:58AM -0400, Jeff King wrote:
> So probably we should:
>
> 1. Pass the empty tree along to merge-resolve. This will take a little
> bit of refactoring, but more importantly, it means we will be
> passing a tree-ish and not a commit-ish to a merge strategy. Is
> that OK?
>
> 2. Consider lifting the restriction on reverting root commits. If we
> can cherry-pick it, we can revert it, so I suspect this would
> already work with merge-recursive, but I didn't try. I don't care
> too much either way, though; I doubt it's something people would do
> a lot. It just seems like an unnecessary restriction.
This turned out to be quite easy. git-merge-resolve handles the tree-ish
argument just fine. But it's possible other merge helpers might not be
so happy. I dunno.
The series is:
[1/3]: cherry-pick: handle root commits with external strategies
[2/3]: revert: allow reverting a root commit
[3/3]: t3503: test cherry picking and reverting root commits
-Peff
next prev parent reply other threads:[~2011-05-12 11:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 10:15 git cherry-pick --strategy=resolve segfaults if picking a root commit Sebastian Schuberth
2011-05-12 10:45 ` Jeff King
2011-05-12 11:08 ` Jeff King [this message]
2011-05-12 11:09 ` [PATCH 1/3] cherry-pick: handle root commits with external strategies Jeff King
2011-05-12 14:50 ` Sebastian Schuberth
2011-05-12 11:09 ` [PATCH 2/3] revert: allow reverting a root commit Jeff King
2011-05-12 14:53 ` Sebastian Schuberth
2011-05-12 11:10 ` [PATCH 3/3] t3503: test cherry picking and reverting root commits Jeff King
2011-05-12 12:20 ` Johannes Sixt
2011-05-12 12:37 ` Jeff King
2011-05-16 10:27 ` git cherry-pick --strategy=resolve segfaults if picking a root commit Jeff King
2011-05-16 15:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110512110855.GA5240@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).