From: Pete Wyckoff <pw@padd.com>
To: Luke Diamand <luke@diamand.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCHv1] git-p4: test harness directory handling tidyup
Date: Thu, 12 May 2011 07:29:37 -0400 [thread overview]
Message-ID: <20110512112937.GA3128@arf.padd.com> (raw)
In-Reply-To: <1305177299-27130-2-git-send-email-luke@diamand.org>
luke@diamand.org wrote on Thu, 12 May 2011 06:14 +0100:
> The git-p4 test harness relied a lot on cd'ing to the target directory
> and then cd'ing back explicitly. That caused problems if the test failed
> partway through. i.e.
> cd $git && stuff && cd "$TRASH_DIRECTORY"
>
> Instead, use:
> (cd $git && stuff)
>
> Signed-off-by: Luke Diamand <luke@diamand.org>
> Suggested-by: Junio C Hamano <gitster@pobox.com>
I'm glad that Junio noticed and that you took the time to fix
this. It was indeed a problem.
Acked-by: Pete Wyckoff <pw@padd.com>
prev parent reply other threads:[~2011-05-12 11:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 5:14 [PATCHv1] git-p4: test harness directory handling tidyup Luke Diamand
2011-05-12 5:14 ` Luke Diamand
2011-05-12 11:29 ` Pete Wyckoff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110512112937.GA3128@arf.padd.com \
--to=pw@padd.com \
--cc=git@vger.kernel.org \
--cc=luke@diamand.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).