From: Jonathan Nieder <jrnieder@gmail.com>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <junio@kernel.org>
Subject: Re: [PATCH v2] Add log.abbrevCommit config variable
Date: Sat, 14 May 2011 16:55:43 -0500 [thread overview]
Message-ID: <20110514215543.GA23648@elie> (raw)
In-Reply-To: <1305406038-36435-1-git-send-email-jaysoffian@gmail.com>
Jay Soffian wrote:
> Add log.abbrevCommit config variable as a convenience for users who
> often use --abbrev-commit with git log and friends. Allow the option
> to be overridden with --no-abbrev-commit.
Based on a quick google code search, this will break scripts. :/
For example, tig uses "git log --pretty=raw" to get revision lists,
including expecting 40-digit commit ids.
But aside from that, this looks good to me. I'm not sure what to
suggest: go out and spread the word about diff-tree? suppress this
configuration when --pretty or --format is passed? There's no obvious
good answer.
next prev parent reply other threads:[~2011-05-14 21:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 17:22 [PATCH] Add log.abbrev-commit config option Jay Soffian
2011-05-14 17:26 ` Jay Soffian
2011-05-14 19:01 ` Jonathan Nieder
2011-05-14 19:35 ` Jay Soffian
2011-05-14 20:19 ` [PATCH] add, merge, diff: do not use strcasecmp to compare config variable names Jonathan Nieder
2011-05-15 1:53 ` Junio C Hamano
2011-05-14 20:47 ` [PATCH v2] Add log.abbrevCommit config variable Jay Soffian
2011-05-14 21:55 ` Jonathan Nieder [this message]
2011-05-14 22:22 ` Jay Soffian
2011-05-14 22:49 ` [PATCH v3] " Jay Soffian
2011-05-15 13:25 ` Jay Soffian
2011-05-15 22:42 ` Junio C Hamano
2011-05-16 5:53 ` Jay Soffian
2011-05-16 7:00 ` Jonathan Nieder
2011-05-16 7:18 ` Jay Soffian
2011-05-17 17:03 ` Junio C Hamano
2011-05-17 21:50 ` Junio C Hamano
2011-05-18 1:05 ` Jay Soffian
2011-05-17 18:50 ` Junio C Hamano
2011-05-17 19:08 ` Jay Soffian
2011-05-15 1:48 ` [PATCH] Add log.abbrev-commit config option Junio C Hamano
2011-05-16 8:24 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110514215543.GA23648@elie \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
--cc=junio@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).