git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Erik Faye-Lund <kusmabite@gmail.com>
Subject: Re: Bikeshedding advice on the ab/i18n-scripts series
Date: Mon, 16 May 2011 11:26:00 -0500	[thread overview]
Message-ID: <20110516162600.GA25468@elie> (raw)
In-Reply-To: <BANLkTi==pxyy7OeZT0mn33iJHrc5R7vHBw@mail.gmail.com>

Ævar Arnfjörð Bjarmason wrote:

> Oh, and for all the convertion of:
>
>     echo >&2 "$(gettext "foobar")"
>
> I've already done:
>
>     (
>         gettext "foobar" &&
>         echo
>     ) >&2

Some day we might want to introduce a gettext_ln function or something
similar.  But that doesn't seem urgent; I wouldn't be appalled by
having to read 'gettext "foobar" && echo' in a block surrounded by
braces (or even a subshell, even though it makes shells waste a
fork()).

As for what to call the envvars, I have no strong preference there,
either.  If you don't care about compatibility with the real gettext.sh
then it should be possible to do the variable munging automatically,
using a loop:

	for var in $(git sh-i18n--envsubst --variables "$fmt")
	do
		eval "sh_i18n_$var"=\$var
		export "sh_i18n_$var"
	done

with an understanding that git sh-i18n--envsubst substitutes in
${sh_i18n_$var} where it sees '$var' in the format string.

But if we do want to use the real envsubst some day then that is not
possible.  I dunno.

  reply	other threads:[~2011-05-16 16:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16 16:03 Bikeshedding advice on the ab/i18n-scripts series Ævar Arnfjörð Bjarmason
2011-05-16 16:26 ` Jonathan Nieder [this message]
2011-05-16 20:45 ` Junio C Hamano
2011-05-16 20:53   ` Ævar Arnfjörð Bjarmason
2011-05-16 20:58   ` Junio C Hamano
2011-05-16 21:13     ` Ævar Arnfjörð Bjarmason
2011-05-16 21:26       ` Jonathan Nieder
2011-05-16 21:32         ` Ævar Arnfjörð Bjarmason
2011-05-16 21:40           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110516162600.GA25468@elie \
    --to=jrnieder@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kusmabite@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).