From mboxrd@z Thu Jan 1 00:00:00 1970 From: Raphael Zimmerer Subject: [RFC/PATCH resend] gitk: Mark commits with notes with a yellow box. Date: Mon, 16 May 2011 18:40:29 +0200 Message-ID: <20110516164029.GA28023@rdrz.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Paul Mackerras To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Mon May 16 18:40:37 2011 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QM0qS-0005EJ-Mj for gcvg-git-2@lo.gmane.org; Mon, 16 May 2011 18:40:37 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752196Ab1EPQkb (ORCPT ); Mon, 16 May 2011 12:40:31 -0400 Received: from rdrz.de ([217.160.107.209]:54130 "HELO rdrz.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751715Ab1EPQkb (ORCPT ); Mon, 16 May 2011 12:40:31 -0400 Received: (qmail 20544 invoked by uid 1009); 16 May 2011 16:40:29 -0000 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: It is desirable to see at a glance which commits do contain notes. Therefore mark them with a yellow rectangle. That can be suppressed with `gitk --no-notes`. Signed-off-by: Raphael Zimmerer --- Maybe this patch is helpful. Sorry for any tcl/tk nonsense, it's not my first language... gitk | 17 ++++++++++++++++- 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/gitk b/gitk index 4cde0c4..b182c75 100755 --- a/gitk +++ b/gitk @@ -1674,8 +1674,9 @@ proc parsecommit {id contents listed} { if {$comdate != {}} { set cdate($id) $comdate } + set hasnote [string first "\nNotes:\n" $contents] set commitinfo($id) [list $headline $auname $audate \ - $comname $comdate $comment] + $comname $comdate $comment $hasnote] } proc getcommit {id} { @@ -5899,6 +5900,9 @@ proc drawcmittext {id row col} { || [info exists idotherrefs($id)]} { set xt [drawtags $id $x $xt $y] } + if {[lindex $commitinfo($id) 6] > 0} { + set xt [drawnotesign $xt $y] + } set headline [lindex $commitinfo($id) 0] set name [lindex $commitinfo($id) 1] set date [lindex $commitinfo($id) 2] @@ -6345,6 +6349,17 @@ proc drawtags {id x xt y1} { return $xt } +proc drawnotesign {xt y} { + global linespc canv fgcolor + + set orad [expr {$linespc / 3}] + set t [$canv create rectangle [expr {$xt - $orad}] [expr {$y - $orad}] \ + [expr {$xt + $orad - 1}] [expr {$y + $orad - 1}] \ + -fill yellow -outline $fgcolor -width 1 -tags circle] + set xt [expr {$xt + $orad * 3}] + return $xt +} + proc xcoord {i level ln} { global canvx0 xspc1 xspc2 -- 1.7.5.rc1.12.gff46a