From: Jeff King <peff@peff.net>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] config: define and document exit codes
Date: Wed, 18 May 2011 04:21:30 -0400 [thread overview]
Message-ID: <20110518082130.GG27482@sigill.intra.peff.net> (raw)
In-Reply-To: <6301052eb455e9088e50f78760e6ca1b9499564a.1305646709.git.git@drmicha.warpmail.net>
On Tue, May 17, 2011 at 05:38:52PM +0200, Michael J Gruber wrote:
> The return codes of git_config_set() and friends are magic numbers right
> in the source. #define them in cache.h where the functions are declared,
> and use the constants in the source.
>
> Also, mention the resulting exit codes of "git config" in its man page
> (and complete the list).
This version (and the accompanying 2/2) both look sane to me. Thanks for
taking time to clean up.
-Peff
next prev parent reply other threads:[~2011-05-18 8:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 11:34 [PATCH/RFC] config: Give error message when not changing a multivar Michael J Gruber
2011-05-17 12:38 ` Jeff King
2011-05-17 14:03 ` Michael J Gruber
2011-05-17 14:07 ` Jeff King
2011-05-17 15:38 ` [PATCH 1/2] config: define and document exit codes Michael J Gruber
2011-05-17 15:38 ` [PATCH 2/2] config: Give error message when not changing a multivar Michael J Gruber
2011-05-17 15:46 ` [PATCH 1/2] config: define and document exit codes Thiago Farina
2011-05-17 15:49 ` Michael J Gruber
2011-05-18 8:21 ` Jeff King [this message]
2011-05-18 15:41 ` Junio C Hamano
2011-05-18 18:49 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518082130.GG27482@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).