From: Thomas Rast <trast@student.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
Jeff King <peff@peff.net>, Pete Harlan <pgit@pcharlan.com>,
Hermann Gausterer <git-mailinglist@mrq1.org>,
git list <git@vger.kernel.org>
Subject: Re: [PATCH] add-interactive: shortcut to add hunk and quit
Date: Thu, 19 May 2011 12:16:51 +0200 [thread overview]
Message-ID: <201105191216.51709.trast@student.ethz.ch> (raw)
In-Reply-To: <7vr57wc9ja.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
>
> I think "single-key" was a poorly designed attempt to improve productivity
> the ("y" <RET>)*5 into "y"*5
Actually for me it more often is
y RET n RET *think* y RET s RET n RET ...
> while sacrificing the safety net when you
> are trying to pick and decide one by one (like the accident Thomas had
> recently during "checkout -p"). If I can say "5y", think for half a second
> to make sure I typed what I meant, and <RET>, to apply 5 upcoming hunks in
> one go, I think I would be as efficient as the productivity optimization
> the single-key offers, while still protecting me from mistakes made by fat
> fingers.
There's nothing stopping us from implementing number prefixes in
single-key mode, since numbers do not have any meaning yet.
After my little accident I'm also considering an (optional?) safety
question at the end when in checkout -p mode, since it's inherently
destructive. Of course that first requires changing the whole
operation to be atomic.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2011-05-19 10:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-15 12:55 [PATCH] add-interactive: shortcut for add hunk and quit Hermann Gausterer
2011-05-15 20:30 ` Junio C Hamano
2011-05-16 16:26 ` [PATCH] add-interactive: shortcut to " Hermann Gausterer
2011-05-16 16:37 ` Matthieu Moy
2011-05-17 5:09 ` Junio C Hamano
2011-05-17 7:12 ` Hermann Gausterer
2011-05-18 6:40 ` Pete Harlan
2011-05-18 6:45 ` Jeff King
2011-05-18 9:26 ` Michael J Gruber
2011-05-18 15:28 ` Junio C Hamano
2011-05-19 10:16 ` Thomas Rast [this message]
2011-05-19 11:02 ` Jeff King
2011-05-19 19:25 ` Junio C Hamano
2011-05-19 19:42 ` Jeff King
2011-05-18 8:43 ` Hermann Gausterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105191216.51709.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git-mailinglist@mrq1.org \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=pgit@pcharlan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).