git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Rafael Gieschke <rafael@gieschke.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCHv2] add Android support
Date: Thu, 19 May 2011 13:38:51 -0400	[thread overview]
Message-ID: <20110519173851.GA12295@sigill.intra.peff.net> (raw)
In-Reply-To: <AE42113D-8D2F-4B24-A800-D49183152911@gieschke.de>

On Thu, May 19, 2011 at 07:30:49PM +0200, Rafael Gieschke wrote:

> > The point of uname_S is that it would be found automatically. Sadly,
> > There is nothing helpful in uname to tell us that we are on android:
> 
> Actually, you can't even call uname as I suspect that you would
> normally not compile on Android (I don't think that gcc runs on
> Android) but always cross-compile.

Good point. Whatever support we provide will need to be user-configured,
then.

> > So I think we are probably stuck either with the user setting an ANDROID
> > meta-flag that sets the other flags appropriately, or leaving it up to
> > the user to provide a sane config.mak.
> 
> Yes, I agree that leaving it up completely to the user to provide a
> config.mak is a very good option too, especially as build environments
> might be different and some might want to try building with Perl and
> libcurl, which would require a config.mak anyhow.

I don't know enough about Android development to know how much
commonality there is between devices and builds. AFAIK, the Android spec
itself only provides the Java-callable API. So for Unix-y stuff like
this, I have no idea what is on stock Android versus Cyanogen for
instance, or even if what is on stock varies from handset to handset.

So yeah, we are probably better not even trying to provide a default set
of flags for Android; we can support specific hacks (like your patches 1
and 2) but leave it up to individual build environments to enable them
as appropriate.

-Peff

  reply	other threads:[~2011-05-19 17:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16 23:23 [PATCHv2] add Android support Rafael Gieschke
2011-05-19  6:18 ` Junio C Hamano
2011-05-19 11:37   ` Rafael Gieschke
2011-05-19 12:20     ` Jeff King
2011-05-19 17:30       ` Rafael Gieschke
2011-05-19 17:38         ` Jeff King [this message]
2011-05-19 19:27           ` Rafael Gieschke
2011-05-23  7:04       ` Cross-compiling git (was: [PATCHv2] add Android support) Jakub Narebski
2011-05-23 14:30         ` Jeff King
2011-05-25 14:20           ` Jakub Narebski
2011-05-25 15:06             ` Jeff King
2011-05-19 14:17     ` [PATCHv2] add Android support Junio C Hamano
2011-05-23  8:01   ` Tor Arntsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110519173851.GA12295@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rafael@gieschke.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).