Re: [PATCH 2/4] basic priority queue implementation

[Jeff King <peff@peff.net>]

On Thu, May 19, 2011 at 09:47:38PM -0300, Thiago Farina wrote:

> > +void queue_insert(struct queue *pq, void *item);
> I'd rename this to queue_append as we add |item| to the end of the
> array (like you did for sha1_array_append), opposed of inserting it at
> some position/index.

It's definitely not an append. The data structure is a priority queue,
so the element is inserted within the heap at the proper position
according to the comparison function (notice that we stick at the end,
but then heapify_up).

Speaking of naming, though, the real problem is that this data structure
should be called "pqueue" or something similar to indicate that it is
not a simple FIFO. Unfortunately, the short-and-sweet "pqueue" is taken
by openssl, which pollutes all over the global namespace.

-Peff

PS If you don't mind, please try to trim your quoted text a bit. Finding
your 3-line paragraph amid 200 lines of quoted text was a little
challenging. :)