From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Allow built-ins to also use -c var=val via alias
Date: Tue, 24 May 2011 17:57:59 -0400 [thread overview]
Message-ID: <20110524215759.GA24298@sigill.intra.peff.net> (raw)
In-Reply-To: <20110524215202.GA22243@sigill.intra.peff.net>
On Tue, May 24, 2011 at 05:52:02PM -0400, Jeff King wrote:
> On Tue, May 24, 2011 at 05:46:18PM -0400, Jeff King wrote:
>
> > I think the right fix is simply to drop the "don't re-check the
> > environment after the first time" logic. It's not expensive to parse
> > compared to parsing config files, which is when we would do it. We can
> > just drop the existing list and reparse. You can even get rid of the
> > whole list and drop a bunch of code, I think, like:
>
> Ack, wrong patch. That one doesn't even come close to compiling.
>
> Try this (still not well tested, though).
Ugh, broken. That will teach me to just paste any random junk into my
MUA. Hopefully you got the gist of what I was trying to say, but let me
come up with a more readable and tested series.
-Peff
next prev parent reply other threads:[~2011-05-24 21:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 21:15 [PATCH] handle_options(): do not miscount how many arguments were used Junio C Hamano
2011-05-24 21:18 ` [PATCH] Allow built-ins to also use -c var=val via alias Junio C Hamano
2011-05-24 21:46 ` Jeff King
2011-05-24 21:52 ` Jeff King
2011-05-24 21:57 ` Jeff King [this message]
2011-05-24 22:49 ` Jeff King
2011-05-24 22:49 ` [PATCH 1/4] config: make environment parsing routines static Jeff King
2011-05-24 22:49 ` [PATCH 2/4] git_config: don't peek at global config_parameters Jeff King
2011-05-24 22:49 ` [PATCH 3/4] config: always parse GIT_CONFIG_PARAMETERS during git_config Jeff King
2011-05-24 22:50 ` [PATCH 4/4] handle_options(): do not miscount how many arguments were used Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110524215759.GA24298@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).