From: Chris Wilson <cwilson@vigilantsw.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: [PATCH] Remove a dead assignment
Date: Wed, 25 May 2011 11:06:32 -0400 [thread overview]
Message-ID: <20110525150631.GA29161@localhost> (raw)
In-Reply-To: <vpqfwo3ush3.fsf@bauges.imag.fr>
On Wed, May 25, 2011 at 09:52:56AM +0200, Matthieu Moy wrote:
> Chris Wilson <cwilson@vigilantsw.com> writes:
>
> > Oops, I see others putting the patches inline. Here you go.
>
> Please, read Documentation/SubmittingPatches. Especially read about
> signed-off-by and the way patches should be formatted (git send-email
> would help).
Thanks, trying this again. Like I said before, the author should
investigate if this variable should have been used before removing it.
Signed-off-by: Chris Wilson <cwilson@vigilantsw.com>
---
sh-i18n--envsubst.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/sh-i18n--envsubst.c b/sh-i18n--envsubst.c
index 7125093..5829463 100644
--- a/sh-i18n--envsubst.c
+++ b/sh-i18n--envsubst.c
@@ -67,9 +67,6 @@ static void subst_from_stdin (void);
int
main (int argc, char *argv[])
{
- /* Default values for command line options. */
- unsigned short int show_variables = 0;
-
switch (argc)
{
case 1:
@@ -88,7 +85,6 @@ main (int argc, char *argv[])
/* git sh-i18n--envsubst --variables '$foo and $bar' */
if (strcmp(argv[1], "--variables"))
error ("first argument must be --variables when two are given");
- show_variables = 1;
print_variables (argv[2]);
break;
default:
--
1.7.5.2.354.g19aea
next prev parent reply other threads:[~2011-05-25 15:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 21:07 Simple dead assignment Chris Wilson
2011-05-24 22:45 ` [PATCH] " Chris Wilson
2011-05-25 7:52 ` Matthieu Moy
2011-05-25 15:06 ` Chris Wilson [this message]
2011-05-25 15:50 ` [PATCH] Remove a " Matthieu Moy
2011-05-25 17:18 ` Michael Schubert
2011-05-25 18:45 ` Chris Wilson
2011-05-25 19:11 ` Junio C Hamano
2011-05-25 19:23 ` Junio C Hamano
2011-05-25 19:45 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110525150631.GA29161@localhost \
--to=cwilson@vigilantsw.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).