From: Chris Wilson <cwilson@vigilantsw.com>
To: Michael Schubert <mschub@elegosoft.com>
Cc: "Matthieu Moy" <Matthieu.Moy@grenoble-inp.fr>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: [PATCH] Remove a dead assignment
Date: Wed, 25 May 2011 14:45:14 -0400 [thread overview]
Message-ID: <20110525184514.GA20005@localhost> (raw)
In-Reply-To: <4DDD3A01.6040407@elegosoft.com>
The assignment to fmt is dead and is also useless.
Signed-off-by: Chris Wilson <cwilson@vigilantsw.com>
---
On Wed, May 25, 2011 at 07:18:57PM +0200, Michael Schubert wrote:
> There already is a patch on its way:
>
> http://article.gmane.org/gmane.comp.version-control.git/174378
Thanks! Well, I wasn't going to report this dead assignment since
it wasn't done recently, but now I want to figure out how to properly
submit a patch. :) Am I there yet? and thanks for the help.
Thanks,
CHris
pretty.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/pretty.c b/pretty.c
index dff5c8d..5667c7f 100644
--- a/pretty.c
+++ b/pretty.c
@@ -1082,7 +1082,6 @@ void userformat_find_requirements(const char *fmt, struct userformat_
if (!fmt) {
if (!user_format)
return;
- fmt = user_format;
}
strbuf_expand(&dummy, user_format, userformat_want_item, w);
strbuf_release(&dummy);
--
1.7.5.2.354.g19aea
next prev parent reply other threads:[~2011-05-25 18:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 21:07 Simple dead assignment Chris Wilson
2011-05-24 22:45 ` [PATCH] " Chris Wilson
2011-05-25 7:52 ` Matthieu Moy
2011-05-25 15:06 ` [PATCH] Remove a " Chris Wilson
2011-05-25 15:50 ` Matthieu Moy
2011-05-25 17:18 ` Michael Schubert
2011-05-25 18:45 ` Chris Wilson [this message]
2011-05-25 19:11 ` Junio C Hamano
2011-05-25 19:23 ` Junio C Hamano
2011-05-25 19:45 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110525184514.GA20005@localhost \
--to=cwilson@vigilantsw.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mschub@elegosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).