From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Jeff King <peff@peff.net>, GIT Mailing-list <git@vger.kernel.org>,
David Barr <david.barr@cordelta.com>
Subject: [PULL svn-fe/maint] t0081-*.sh: Fix failure of the 'long read' tests
Date: Wed, 25 May 2011 23:33:35 -0500 [thread overview]
Message-ID: <20110526043335.GB17479@elie> (raw)
In-Reply-To: <4DBC45F9.7090804@ramsay1.demon.co.uk>
Hi,
Ramsay Jones wrote:
> So, the patch is correct, but (apart from the last sentence) the
> commit message is *absolute rubbish*. I won't bore you with the
> details of my lunacy! :-P
>
> However, I much prefer Jonathan's patch which removes this test
> completely!
Junio, please pull
git://repo.or.cz/git/jrn.git svn-fe-maint
to receive the following fix. The patch first visited the list two
months ago[1] and was discussed again last month[2] and seems to have
been well liked both times (well, I know I like it).
The tests it removes
- are missing an EXECKEEPSPID prerequisite on Windows
- use a : $((i = i + 1)) construct which does not seem to be portable
to old versions of dash
- are pointless, an eyesore, and a pain to maintain
What was the author thinking? Sorry to let this sit for so long.
Jonathan Nieder (1):
Revert "t0081 (line-buffer): add buffering tests"
t/t0081-line-buffer.sh | 106 +-----------------------------------------------
1 files changed, 2 insertions(+), 104 deletions(-)
[1] http://thread.gmane.org/gmane.comp.version-control.git/170307/focus=170365
[2] http://thread.gmane.org/gmane.comp.version-control.git/172120/focus=172523
next prev parent reply other threads:[~2011-05-26 4:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 18:05 [RFC/PATCH] t0081-*.sh: Fix failure of the 'long read' tests Ramsay Jones
2011-04-26 19:35 ` Jonathan Nieder
2011-04-30 17:12 ` Ramsay Jones
2011-04-26 23:48 ` Jeff King
2011-04-30 17:25 ` Ramsay Jones
2011-05-26 4:33 ` Jonathan Nieder [this message]
2011-05-26 16:03 ` [PULL svn-fe/maint] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110526043335.GB17479@elie \
--to=jrnieder@gmail.com \
--cc=david.barr@cordelta.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).