From: Jeff King <peff@peff.net>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Jimmie WESTER <jimmie.wester@stericsson.com>
Subject: Re: [PATCH] remote: allow "-t" with fetch mirrors
Date: Thu, 26 May 2011 11:28:56 -0400 [thread overview]
Message-ID: <20110526152855.GA4120@sigill.intra.peff.net> (raw)
In-Reply-To: <4DDE7116.4070900@viscovery.net>
On Thu, May 26, 2011 at 05:26:14PM +0200, Johannes Sixt wrote:
> Am 5/26/2011 17:11, schrieb Jeff King:
> > + if (mirror && !(mirror & MIRROR_FETCH) && track.nr)
> > + die("specifying branches to track makes no sense with non-fetch mirrors");
>
> Don't proliferate no double negation. How about:
>
> + die("specifying branches to track makes sense only with fetch mirrors");
I can't fail to not disagree with your logic.
Junio, can you squash it in?
-Peff
next prev parent reply other threads:[~2011-05-26 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 15:11 [PATCH] remote: allow "-t" with fetch mirrors Jeff King
2011-05-26 15:26 ` Johannes Sixt
2011-05-26 15:28 ` Jeff King [this message]
2011-05-26 17:08 ` Junio C Hamano
2011-05-26 17:31 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110526152855.GA4120@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=jimmie.wester@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).