From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jimmie WESTER <jimmie.wester@stericsson.com>
Subject: Re: [PATCH] remote: allow "-t" with fetch mirrors
Date: Thu, 26 May 2011 13:31:06 -0400 [thread overview]
Message-ID: <20110526173106.GA2608@sigill.intra.peff.net> (raw)
In-Reply-To: <7vk4ddxucf.fsf@alter.siamese.dyndns.org>
On Thu, May 26, 2011 at 10:08:48AM -0700, Junio C Hamano wrote:
> > So 13fc2c1 was overly constrictive, and disallowed
> > reasonable specific-branch mirroring, like:
> >
> > git remote add -t heads/foo -t heads/bar --mirror=fetch
>
> I mildly disagree that it is "reasonable". I would understand if it were
> something like this:
>
> git remote add -t heads/foo:heads/foo -t heads/bar:heads/bar
>
> I am not saying selective copying is bad or useless. It would be useful
> in some situations. I am saying that is not a mirror, and reusing the
> same --mirror option for a different meaning may introduce confusion.
I think of it as "you are mirroring these specific refs to your
repository" instead of "you are fetching these specific refs into remote
tracking branches". But it is somewhat a matter of semantics.
I agree that allowing generalized refspecs via "-t" is a nicer solution
in the long run. I am mostly trying to fix a regression in 13fc2c1
here; I guess the question is whether it is one worth fixing, or if
people who want to do this in the meantime should just use "git config".
-Peff
prev parent reply other threads:[~2011-05-26 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 15:11 [PATCH] remote: allow "-t" with fetch mirrors Jeff King
2011-05-26 15:26 ` Johannes Sixt
2011-05-26 15:28 ` Jeff King
2011-05-26 17:08 ` Junio C Hamano
2011-05-26 17:31 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110526173106.GA2608@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jimmie.wester@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).