From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Cc: John 'Warthog9' Hawley <warthog9@kernel.org>,
Petr Baudis <pasky@suse.cz>, Fredrik Kuivinen <frekui@gmail.com>,
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>,
Luben Tuikov <ltuikov@yahoo.com>,
Martin Koegler <mkoegler@auto.tuwien.ac.at>
Subject: Re: [PATCH 0/3] gitweb: Improving blame_incremental.js
Date: Fri, 27 May 2011 16:04:38 +0200 [thread overview]
Message-ID: <201105271604.41731.jnareb@gmail.com> (raw)
In-Reply-To: <1306504201-18014-1-git-send-email-jnareb@gmail.com>
Jakub Narebski wrote:
> Two first patches remove unnecessary code from JavaScript-side of
> blame_incremental code. [...]
>
> So those two are pure simplification.
>
>
> The third (last) patch replaces setInterval (where events might
> accumulate if browser is very busy) to recommended re-enabled
> setTimeout. [...]
>
> This one adds more code than it removes, and could be split into two
> patches: [...]
I forgot to add that this series is based on top of jn/gitweb-js
series, namely it theoretically require "gitweb: Split JavaScript for
maintability, combining on build"... but thanks to Git rename detection
it should [had] apply on top of master as well.
--
Jakub Narebski
Poland
prev parent reply other threads:[~2011-05-27 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 13:49 [PATCH 0/3] gitweb: Improving blame_incremental.js Jakub Narebski
2011-05-27 13:49 ` [PATCH 1/3] gitweb.js: No need for inProgress in blame_incremental.js Jakub Narebski
2011-05-27 13:50 ` [PATCH 2/3] gitweb.js: No need for loop in blame_incremental's handleResponse() Jakub Narebski
2011-05-27 13:50 ` [PATCH 3/3] gitweb.js: use setTimeout rather than setInterval in blame_incremental.js Jakub Narebski
2011-05-27 14:04 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105271604.41731.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=frekui@gmail.com \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=ltuikov@yahoo.com \
--cc=mkoegler@auto.tuwien.ac.at \
--cc=pasky@suse.cz \
--cc=warthog9@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).