From: "Carlos Martín Nieto" <cmn@elego.de>
To: Gustaf Hendeby <hendeby@isy.liu.se>
Cc: git@vger.kernel.org
Subject: Re: git show and the --quiet option
Date: Sat, 28 May 2011 19:26:11 +0200 [thread overview]
Message-ID: <20110528172611.GB28708@centaur.lab.cmartin.tk> (raw)
In-Reply-To: <4DE12888.1040506@isy.liu.se>
[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]
On Sat, May 28, 2011 at 06:53:28PM +0200, Gustaf Hendeby wrote:
> Hello everyone,
>
> I was playing around with "git show" lately and realized it has changed
> its behavior regarding the --quiet option, which no longer suppresses
> the diff output as it used to. The behavior change happened in
> 1c40c36b ("log: convert to parse-options"). Was this intentional?
Very much so.
>
> The commit message talks about the --quiet handling being improved and
> the "git show" help doesn't mention a --quiet option. Is the simple
> answer that the previous behavior was incorrect?
Yes.
The long answer is that the log family (and git-format-patch, which
is where this started) never actually accepted --quiet, so it would
get passed down to the diff machinery. This (for complicated reasons
I'm not sure I comletely understand, but that have to do with the
internal handling of 'quiet' as 'quick') caused every second commit
not to show.
As you noticed, the man page never mentions a --quiet option
(because, honestly, it doesn't make any sense), so any use of that
flag is wrong. Part of what the patch does is make --quiet a no-op to
guard against the effect of disappearing commits.
How are you using the --quiet option and why would you even need it?
Cheers,
cmn
--
Carlos Martín Nieto | http://cmartin.tk
"¿Cómo voy a decir bobadas si soy mudo?" -- CACHAI
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-05-28 17:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 16:53 git show and the --quiet option Gustaf Hendeby
2011-05-28 17:26 ` Carlos Martín Nieto [this message]
2011-05-28 18:03 ` Gustaf Hendeby
2011-05-29 13:24 ` Carlos Martín Nieto
2011-05-28 19:17 ` Junio C Hamano
2011-05-30 9:32 ` Carlos Martín Nieto
2011-06-02 18:26 ` Drew Northup
2011-06-05 23:13 ` Carlos Martín Nieto
2011-05-28 17:55 ` Junio C Hamano
2011-05-28 18:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110528172611.GB28708@centaur.lab.cmartin.tk \
--to=cmn@elego.de \
--cc=git@vger.kernel.org \
--cc=hendeby@isy.liu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).