Re: [PATCH 3/3] gitk: Allow displaying time zones from author and commit timestamps

[Paul Mackerras <paulus@samba.org>]

On Wed, Jan 19, 2011 at 02:47:52PM -0500, Anders Kaseorg wrote:

> Now gitk can be configured to display author and commit dates in their
> original timezone, by putting %z into datetimeformat in ~/.gitk.
> 
> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
> ---
>  gitk |   13 ++++++++++++-
>  1 files changed, 12 insertions(+), 1 deletions(-)
> 
> diff --git a/gitk b/gitk
> index 5c6058a..a072593 100755
> --- a/gitk
> +++ b/gitk
> @@ -11018,7 +11018,18 @@ proc prefsok {} {
>  proc formatdate {d} {
>      global datetimeformat
>      if {$d ne {}} {
> -	set d [clock format [lindex $d 0] -format $datetimeformat]
> +	if {[string match {*%[zZ]*} $datetimeformat]} {
> +	    if {[catch {set d [clock format [lindex $d 0] -timezone [lindex $d 1] -format $datetimeformat]}]} {
> +		# Tcl < 8.5 does not support -timezone.
> +		global env
> +		set zone [lindex $d 1]
> +		set env(TZ) "IDK[string range $zone 0 2]:[string range $zone 3 end]"

What is this about?  Where is the IDK prefix for timezones defined or
described?

> +		set d [clock format [lindex $d 0] -format $datetimeformat]
> +		unset env(TZ)

Oops, we just lost any previous setting of TZ...

Paul.