git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Tim Guirgies <lt.infiltrator@gmail.com>
Cc: Anders Kaseorg <andersk@mit.edu>,
	Paul Mackerras <paulus@samba.org>,
	git@vger.kernel.org
Subject: Re: [PATCH 3/3] gitk: Allow displaying time zones from author and commit timestamps
Date: Mon, 30 May 2011 08:29:51 +0200	[thread overview]
Message-ID: <201105300829.52619.jnareb@gmail.com> (raw)
In-Reply-To: <20110530061757.GC3723@Imperial-SD-Longsword>

Tim Guirgies wrote:
> On Sun, May 29, 2011 at 10:35:08PM -0700, Jakub Narebski wrote:
> > Anders Kaseorg <andersk@MIT.EDU> writes:

[...]
> > > Yeah, sorry, that deserved a bit more explanation.  This is a kludge to 
> > > get Tcl 8.4 to format dates in the right timezone.  IDK is an arbitrary 
> > > made up 3-letter code (“I Don’t Know”), since a UTC offset can’t generally 
> > > be converted into a zone name.  The format of TZ is described at:
> > > http://www.gnu.org/software/libc/manual/html_node/TZ-Variable.html
> > > http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html
> > > 
> > > Actually, reading that again, I just realized that I need to invert the 
> > > sign.  Also that it can be longer than 3 letters; I’ll use “Unknown” 
> > > instead.
> > 
> > Why not use UTC+N timezone (note: please check of for +HHMM it is
> > UTC+HH or UTC-HH) for timezone with given numeric offset from
> > Coordinated Universal Time?
> > 
> > BTW. UTC because http://www.nist.gov/pml/div688/utcnist.cfm#cut
> 
> But what of half-hour offsets, in that case?  A better idea would be
> UTC+HHMM or UTC-HHMM.  As an example, SA (CST) has a timezone of
> UTC+0930.

I think full specification is UTC+HH:MM or UTC-HH:MM.  GNU date
understands 'TZ=UTC+09:30 date'.


P.S. I should have remembered about fractional timezones, as we have had
problems in gitweb with those... and I have checked then that git.git
repository includes some commits in fractional timezones.

-- 
Jakub Narebski
Poland

  reply	other threads:[~2011-05-30  6:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19 19:46 [PATCH 1/3] gitk: Remove unused $cdate array Anders Kaseorg
2011-01-19 19:47 ` [PATCH 2/3] gitk: Remember time zones from author and commit timestamps Anders Kaseorg
2011-01-19 19:47 ` [PATCH 3/3] gitk: Allow displaying " Anders Kaseorg
2011-05-29  4:46   ` Paul Mackerras
2011-05-30  3:05     ` Anders Kaseorg
2011-05-30  3:06       ` [PATCH v2 " Anders Kaseorg
2011-05-30 19:35         ` Andreas Schwab
2011-05-30 21:45           ` Anders Kaseorg
2011-05-30 21:47             ` [PATCH v3 " Anders Kaseorg
2011-05-30  5:35       ` [PATCH " Jakub Narebski
2011-05-30  6:17         ` Tim Guirgies
2011-05-30  6:29           ` Jakub Narebski [this message]
2011-05-30 21:35             ` Anders Kaseorg
2011-05-30 22:17               ` Andreas Schwab
2011-05-30 22:41                 ` [PATCH v4 " Anders Kaseorg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201105300829.52619.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=andersk@mit.edu \
    --cc=git@vger.kernel.org \
    --cc=lt.infiltrator@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).