From: Jeff King <peff@peff.net>
To: Romain Geissler <romain.geissler@gmail.com>
Cc: git@vger.kernel.org, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: Git global usage and tests
Date: Mon, 30 May 2011 12:12:30 -0400 [thread overview]
Message-ID: <20110530161230.GA25291@sigill.intra.peff.net> (raw)
In-Reply-To: <B369AA28-DEF2-48F3-8E4E-F387E8A57D26@gmail.com>
On Mon, May 30, 2011 at 06:10:20PM +0200, Romain Geissler wrote:
> > Have you considered pulling the parse-options parser from git into
> > libgit2? It's one of the more modularized and lib-ified bits of code in
> > git already.
>
> Yes and No. We have already copied some code from git : parse-option,
> the error handling functions, a part of the run-command block and a
> part of the compatibility layer. To my mind, there is no reason to
> pull it into libgit2 as it's only a client feature that works on
> strings, and libgit2 does not aim at being a client, only a git
> library.
Yeah, good point. Definitely it should not be part of the libgit2
library itself.
-Peff
next prev parent reply other threads:[~2011-05-30 16:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 14:58 Git global usage and tests Romain Geissler
2011-05-30 15:36 ` Jeff King
2011-05-30 16:10 ` Romain Geissler
2011-05-30 16:12 ` Jeff King [this message]
2011-05-31 5:12 ` Miles Bader
2011-05-31 9:05 ` Carlos Martín Nieto
2011-05-31 5:19 ` Junio C Hamano
2011-05-31 11:52 ` Ævar Arnfjörð Bjarmason
2011-05-31 15:04 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110530161230.GA25291@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=romain.geissler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).