From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Romain Geissler <romain.geissler@gmail.com>,
git@vger.kernel.org, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: Git global usage and tests
Date: Tue, 31 May 2011 11:04:55 -0400 [thread overview]
Message-ID: <20110531150455.GA2594@sigill.intra.peff.net> (raw)
In-Reply-To: <BANLkTinW_se8VAhF9wk3KyzNHVc_wH_PqA@mail.gmail.com>
On Tue, May 31, 2011 at 01:52:31PM +0200, Ævar Arnfjörð Bjarmason wrote:
> > IIRC, libgit2 has a lot looser license than ours, and the core GPLv2 part
> > of C git cannot be directly copied without authors' consent; relicensing
> > of necessary parts of C git needs to be arranged.
>
> Seems like a PITA:
Some of the permission has already been granted. There is a file in
libgit2 documenting who has done so. The set difference is:
$ git log --format=%an parse-options.[ch] | sort -u >need
$ perl -lne 'print $1 if /^ok\s+(.*) </' libgit2/git.git-authors >have
$ comm -23 need have >remaining; cat remaining
Alex Riesen
Andreas Schwab
Carlos Rica
Gary V. Vaughan
Giuseppe Scrivano
Jake Goulding
Jonathan Nieder
Mark Lodato
Michael J Gruber
Michele Ballabio
Mike Ralphson
Miklos Vajna
Nanako Shiraishi
Olivier Marin
Stephen Boyd
Thomas Rast
Tuncer Ayaz
which gets us halfway there. A few of the remaining contributions are
quite small, too:
$ git blame --line-porcelain parse-options.c |
perl -lne 'print $1 if /author (.*)/' |
sort | uniq -c |
perl -pe 's/(\d+) /$1\t/' >count
$ join -1 1 -2 2 -t "`printf '\t'`" -o "2.1 2.2" remaining count
4 Alex Riesen
3 Andreas Schwab
23 Giuseppe Scrivano
16 Jake Goulding
38 Jonathan Nieder
16 Mark Lodato
7 Michele Ballabio
1 Nanako Shiraishi
1 Olivier Marin
46 Stephen Boyd
24 Thomas Rast
22 Tuncer Ayaz
Fixing a typo or tweaking the "static" designator on a function is
probably not copyrightable. And some of the medium-sized bits could
possibly be dropped. Still, it is nice to be mindful of the
contributions of others and get permission from everyone.
At any rate, the parse-options code would be linked into the new git2
binary, which should probably be GPL'd, anyway.
-Peff
prev parent reply other threads:[~2011-05-31 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 14:58 Git global usage and tests Romain Geissler
2011-05-30 15:36 ` Jeff King
2011-05-30 16:10 ` Romain Geissler
2011-05-30 16:12 ` Jeff King
2011-05-31 5:12 ` Miles Bader
2011-05-31 9:05 ` Carlos Martín Nieto
2011-05-31 5:19 ` Junio C Hamano
2011-05-31 11:52 ` Ævar Arnfjörð Bjarmason
2011-05-31 15:04 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531150455.GA2594@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=romain.geissler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).