From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Yasushi SHOJI <yashi@atmark-techno.com>, git@vger.kernel.org
Subject: Re: Re* diff: --quiet does not imply --exit-code if --diff-filter is present
Date: Tue, 31 May 2011 13:14:01 -0400 [thread overview]
Message-ID: <20110531171401.GA12466@sigill.intra.peff.net> (raw)
In-Reply-To: <7vd3iykdej.fsf_-_@alter.siamese.dyndns.org>
On Tue, May 31, 2011 at 10:06:44AM -0700, Junio C Hamano wrote:
> Add "exiting_early" field to unpack_trees_options structure, to signal the
> unpack_trees() machinery that the negative return value is not signaling
> an error but an early return from the unpack_trees() machinery. As this by
> definition hasn't unpacked everything, discard the resulting index just
> like the failure codepath.
Maybe it is just me, but I would think that it's a little more intuitive
to set exiting_early and then return "0" to indicate "success, but I
didn't look at everything".
I guess you did it this way to better share the discard-the-result
codepath. Maybe it wouldn't be too painful to refactor unpack_failed()
into the failed bits plus a call to a new unpack_discard() that does the
non-error bits. It may not be worth the trouble though.
-Peff
next prev parent reply other threads:[~2011-05-31 17:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 10:34 diff: --quiet does not imply --exit-code if --diff-filter is present Yasushi SHOJI
2011-05-31 15:33 ` Jeff King
2011-05-31 15:46 ` Junio C Hamano
2011-05-31 16:25 ` Jeff King
2011-05-31 17:06 ` Re* " Junio C Hamano
2011-05-31 17:14 ` Jeff King [this message]
2011-05-31 17:36 ` Junio C Hamano
2011-06-01 9:41 ` Yasushi SHOJI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531171401.GA12466@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=yashi@atmark-techno.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).