From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Chengwei Ding <waterding@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: git annotate with date option not working?
Date: Wed, 1 Jun 2011 14:37:04 -0500 [thread overview]
Message-ID: <20110601193704.GA9950@elie> (raw)
In-Reply-To: <20110601164904.GD7132@sigill.intra.peff.net>
Jeff King wrote:
> Having said that, this would be really easy to support, and I don't
> think would have any negative compatibility consequences, as long as we
> don't support blame.date. But I don't think we're breaking anybody
> relying on "git annotate --date=whatever" being silently ignored, as
> that option has never done anything useful.
>
> The patch would look like this:
Looks obviously good to me. Chengwei (and anyone else), would you be
interested in moving this forward by adding tests and perhaps
documentation?
Thanks.
prev parent reply other threads:[~2011-06-01 19:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 8:20 git annotate with date option not working? Chengwei Ding
2011-06-01 9:40 ` Jakub Narebski
2011-06-01 12:31 ` Chengwei Ding
2011-06-01 9:41 ` Arnaud Lacurie
2011-06-01 12:33 ` Chengwei Ding
2011-06-01 16:16 ` Jeff King
2011-06-01 16:28 ` Chengwei Ding
2011-06-01 16:49 ` Jeff King
2011-06-01 19:37 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110601193704.GA9950@elie \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=waterding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).