From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH 3/3] clone: always fetch remote HEAD Date: Fri, 3 Jun 2011 01:43:03 -0400 Message-ID: <20110603054303.GA5341@sigill.intra.peff.net> References: <20110603050901.GA883@sigill.intra.peff.net> <20110603051805.GC1008@sigill.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Junio C Hamano , Dmitry Ivankov , git@vger.kernel.org, Jonathan Nieder To: Sverre Rabbelier X-From: git-owner@vger.kernel.org Fri Jun 03 07:43:13 2011 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QSNA9-0001pc-Da for gcvg-git-2@lo.gmane.org; Fri, 03 Jun 2011 07:43:13 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752292Ab1FCFnI (ORCPT ); Fri, 3 Jun 2011 01:43:08 -0400 Received: from 99-108-226-0.lightspeed.iplsin.sbcglobal.net ([99.108.226.0]:45444 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565Ab1FCFnH (ORCPT ); Fri, 3 Jun 2011 01:43:07 -0400 Received: (qmail 5471 invoked by uid 107); 3 Jun 2011 05:43:10 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) (smtp-auth username relayok, mechanism cram-md5) by peff.net (qpsmtpd/0.84) with ESMTPA; Fri, 03 Jun 2011 01:43:10 -0400 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 03 Jun 2011 01:43:03 -0400 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Fri, Jun 03, 2011 at 12:36:50AM -0500, Sverre Rabbelier wrote: > On Fri, Jun 3, 2011 at 00:18, Jeff King wrote: > > So I guess it doesn't like us asking for HEAD. But the fact that it > > sends weird data to fast-import instead of saying "hey, HEAD doesn't > > exist" has me confused. I'm not sure if this is something one should not > > be doing with remote helpers, or if the testgit helper is simply buggy > > or incomplete. > > Definitely the latter, quite possibly the former. I don't know if > asking for "HEAD" makes much sense in a remote-helper context though. > In Mercurial it does (e.g., tip), and in svn sort of, but I don't know > about other vcs-es. Perhaps it should be guarded by a capability? Yeah, I think it depends on the helper. Definitely smart-http should be able to do it. But protecting it with a capability does make sense, and then remote helpers can opt into it. -Peff