From: Jakub Narebski <jnareb@gmail.com>
To: Matt McCutchen <matt@mattmccutchen.net>
Cc: git@vger.kernel.org
Subject: Re: Prevalence of $prevent_xss
Date: Sat, 4 Jun 2011 23:53:08 +0200 [thread overview]
Message-ID: <201106042353.08942.jnareb@gmail.com> (raw)
In-Reply-To: <1307222101.5994.13.camel@localhost>
On Sat, 4 Jul 2011, Matt McCutchen wrote:
> On Sat, 2011-06-04 at 10:43 +0200, Jakub Narebski wrote:
> > The fact that it this buglet was present for so long, since its
> > introduction by Matt McCutchen in 7e1100e (gitweb: add $prevent_xss
> > option to prevent XSS by repository content, 2009-02-07) without
> > complaint shows that not many people are using this feature...
Well, and the fact that it is just minor issue (and might not be visible
at all if there is mime.types file, and text files do use mime.types
extensions).
> Yes. Well, I'm still using it, and I found a few mentions on the web:
>
> https://android.git.kernel.org/?p=tools/gerrit.git;a=blob;f=gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitWebServlet.java;h=947fbb423f1f8cf46db9876f4b80c600cdf9ee41;hb=HEAD#l193
> http://ao2.it/wiki/How_to_setup_a_GIT_server_with_gitosis_and_gitweb
> http://www.digitalfoo.net/posts/2009/11/git,_gitosis,_gitweb_on_FreeBSD/
Thanks for research. Nice to know.
> And there are probably others who did their own custom things (GitHub?)
> before the feature was added upstream.
GitHub does not use gitweb, but its own [integrated] custom web interface.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2011-06-04 21:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-04 8:43 [PATCH] gitweb: Fix usability of $prevent_xss Jakub Narebski
2011-06-04 21:15 ` Prevalence " Matt McCutchen
2011-06-04 21:53 ` Jakub Narebski [this message]
2011-06-05 9:03 ` Implementing CSP (Content Security Policy) for gitweb in the future Jakub Narebski
2011-06-05 12:52 ` Matt McCutchen
2011-06-05 13:33 ` Jakub Narebski
2011-06-05 16:46 ` Matt McCutchen
2011-06-08 10:27 ` Jakub Narebski
2011-06-08 17:31 ` J.H.
2011-06-10 12:01 ` [PATCH] gitweb: Make $prevent_xss protection for 'blob_plain' more usable Jakub Narebski
2011-06-13 16:47 ` Junio C Hamano
2011-06-13 21:49 ` Jakub Narebski
2011-06-13 23:12 ` Junio C Hamano
2011-06-14 1:33 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106042353.08942.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=matt@mattmccutchen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).