git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Carlos Martín Nieto" <carlos@cmartin.tk>
To: Drew Northup <drew.northup@maine.edu>
Cc: "Carlos Martín Nieto" <cmn@elego.de>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Gustaf Hendeby" <hendeby@isy.liu.se>,
	git@vger.kernel.org
Subject: Re: git show and the --quiet option
Date: Mon, 6 Jun 2011 01:13:30 +0200	[thread overview]
Message-ID: <20110605231330.GB30081@centaur.lab.cmartin.tk> (raw)
In-Reply-To: <1307039169.28941.35.camel@drew-northup.unet.maine.edu>

[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]

On Thu, Jun 02, 2011 at 02:26:09PM -0400, Drew Northup wrote:
> 
> On Mon, 2011-05-30 at 11:32 +0200, Carlos Martín Nieto wrote:
> > On Sat, May 28, 2011 at 12:17:40PM -0700, Junio C Hamano wrote:
> > > Carlos Martín Nieto <cmn@elego.de> writes:
> > > 
> 
> > > How does this patch look?
> > > 
> > > It does not fix "git show master~10 master^..master", but instead of just
> > > hijacking and ignoring the --quiet option like your patch did, it actually
> > > flips the option the user wanted to affect from the command line.
> > 
> > It's fine if that's what we want to do. The reason I blocked --quiet
> > instead of converting it to -s is because it seemed less surprising
> > than passing --quiet and still getting output (if I pass --quiet, I'd
> > expect the application to really be quiet), which doesn't happen in
> > the commands that accept --quiet on purpose. Then again, the log
> > family doesn't make any sense without any output, so if you argue that
> > way, --quiet means "quieter", which makes the interface less
> > consistent, but I don't feel that strongly about it
> 
> There's a lot of stuff out there for which --quiet does not imply
> --silent. I side with Junio on the solution.

Then don't let me stop you.

   cmn
-- 
Carlos Martín Nieto | http://cmartin.tk

"¿Cómo voy a decir bobadas si soy mudo?" -- CACHAI

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2011-06-05 23:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-28 16:53 git show and the --quiet option Gustaf Hendeby
2011-05-28 17:26 ` Carlos Martín Nieto
2011-05-28 18:03   ` Gustaf Hendeby
2011-05-29 13:24     ` Carlos Martín Nieto
2011-05-28 19:17   ` Junio C Hamano
2011-05-30  9:32     ` Carlos Martín Nieto
2011-06-02 18:26       ` Drew Northup
2011-06-05 23:13         ` Carlos Martín Nieto [this message]
2011-05-28 17:55 ` Junio C Hamano
2011-05-28 18:27   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110605231330.GB30081@centaur.lab.cmartin.tk \
    --to=carlos@cmartin.tk \
    --cc=cmn@elego.de \
    --cc=drew.northup@maine.edu \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hendeby@isy.liu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).