From: Stefano Lattarini <stefano.lattarini@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: Re* [BUG] "git checkout -b" erronously thinks a branch already exists
Date: Mon, 6 Jun 2011 10:26:38 +0200 [thread overview]
Message-ID: <201106061026.38996.stefano.lattarini@gmail.com> (raw)
In-Reply-To: <7v1uz7bkc9.fsf@alter.siamese.dyndns.org>
Hello Junio, and thanks for your quick answer.
On Monday 06 June 2011, Junio C wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
> > I think the right fix is to make sure that "refs/heads/<name>" does not
> > exist by checking exactly that.
> >
> > Perhaps something like this. I am not sure if we want to use the "yield
> > non zero to signal not an error but an early return" trick like I did in
> > this patch, though.
>
> Let's do this instead. I don't know what I was thinking when I wrote that
> inefficient "loop refs to see if there is that one" patch.
>
> [CUT PATCH]
>
I can confirm this change fixes the problem for me.
Thanks,
Stefano
next prev parent reply other threads:[~2011-06-06 8:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 11:05 [BUG] "git checkout -b" erronously thinks a branch already exists Stefano Lattarini
2011-06-06 1:38 ` Re* " Junio C Hamano
2011-06-06 5:27 ` Junio C Hamano
2011-06-06 8:26 ` Stefano Lattarini [this message]
2011-06-06 16:05 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106061026.38996.stefano.lattarini@gmail.com \
--to=stefano.lattarini@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).