git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Peter Kleiweg <p.c.j.kleiweg@rug.nl>
Cc: git@vger.kernel.org
Subject: Re: old but persistent problem: bad line length character
Date: Tue, 7 Jun 2011 14:06:25 -0400	[thread overview]
Message-ID: <20110607180624.GA23752@sigill.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.1.10.1106071832470.4175@localhost>

On Tue, Jun 07, 2011 at 06:33:07PM +0200, Peter Kleiweg wrote:

> I get this error message with git version 1.7.5.GIT: 
> 
>     fatal: protocol error: bad line length character:
> 
> Git version 1.4.4.4 works fine.

I can't reproduce the problem here.  Can you try bisecting to find the
commit that introduces the problem?

> How do bugs in Git get solved? I can't find an issue tracker. 

You send an email to the mailing list and people work on it. :)

> Details:
> 
> $ export GIT_TRACE=1
> $ export GIT_TRACE_PACKET=1
> $ git push 
> trace: built-in: git 'push'
> trace: run_command: 'ssh' 'github' 'git-receive-pack '\''pebbe/Gabmap.git'\''' 
> fatal: protocol error: bad line length character:

Your "ssh github" is weird. Usually that would be "ssh git@github.com",
unless you have set up an alias in .ssh/config. Is that the case? If so,
can you show us the alias? Is it going through a proxy machine or
anything exotic?

> Setting GIT_TRACE_PACKET doesn't seem to have any effect.

That's probably because we never get any packets; the very first one is
bogus, and we abort.

> I added some debug code in pkt-line.c, function 
> packet_read_line(). This tells me that 'buffer' that is passed 
> to packet_read_line() contains nothing but null characters, 
> while 'size' is set to 1000.

Yeah, it's expecting data to be written into it. You need to see what
packet_read_line reads into linelen via safe_read (which is also printed
in the error message, so it looks from the above like it contains NULs).

> Running the ssh command as listed by trace works fine:
> 
> $ ssh github git-receive-pack 'pebbe/Gabmap.git'
> 00720444852406fd34c3eb0c8cdcb05cd2af979d2b34 refs/heads/master report-status delete-refs side-band-64k ofs-delta
> 0000

That looks normal. I wonder why git is not getting the same data.

-Peff

  reply	other threads:[~2011-06-07 18:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-07 16:33 old but persistent problem: bad line length character Peter Kleiweg
2011-06-07 18:06 ` Jeff King [this message]
2011-06-07 22:32   ` Peter Kleiweg
2011-06-08 14:56     ` Junio C Hamano
2011-06-08 17:33       ` Jakub Narebski
2011-06-08 18:33       ` Peter Kleiweg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110607180624.GA23752@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=p.c.j.kleiweg@rug.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).