git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jamey Sharp <jamey@minilop.net>,
	"Shawn O. Pearce" <spearce@spearce.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Jeff King <peff@peff.net>, Jakub Narebski <jnareb@gmail.com>,
	Bert Wesarg <bert.wesarg@googlemail.com>,
	git@vger.kernel.org
Subject: Re: [PATCHv8 1/4] Fix prefix handling in ref iteration functions
Date: Tue, 7 Jun 2011 18:40:01 -0700	[thread overview]
Message-ID: <20110608014001.GA1800@leaf> (raw)
In-Reply-To: <7v4o4141mz.fsf@alter.siamese.dyndns.org>

On Tue, Jun 07, 2011 at 05:17:56PM -0700, Junio C Hamano wrote:
> This round does fix the ".have" issues, but with the --namespace patch
> later in the series, it seems to break the same test, by filtering .have
> entries with "refs/" prefix.

Ouch, missed that; good catch.  We'll fix that in the next round of the
patch series.

> > Commit by Josh Triplett and Jamey Sharp.
> 
> Didn't I ask you to remove this?

You did ask, we responded (with a citation to a specific recommendation
from the Git list saying to include such a note), and you hadn't said
anything further about it until now.  If you insist that we remove it,
fine, we'll remove it.

> It is somewhat irritating having to re-edit the log message (not just this
> part, but what have been queued were retitled, reflowed and reworded to
> match the style of other commits in the project better) over and over
> again.

We attempted to follow the usual commit message conventions, and none of
the feedback we received mentioned anything about any other desired
changes.  What changes would you like us to make?

- Josh Triplett

  reply	other threads:[~2011-06-08  1:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-07 23:04 [PATCHv8 0/4] Support ref namespaces Jamey Sharp
2011-06-07 23:04 ` [PATCHv8 1/4] Fix prefix handling in ref iteration functions Jamey Sharp
2011-06-08  0:17   ` Junio C Hamano
2011-06-08  1:40     ` Josh Triplett [this message]
2011-06-07 23:04 ` [PATCHv8 2/4] Add infrastructure for ref namespaces Jamey Sharp
2011-06-07 23:04 ` [PATCHv8 3/4] Support ref namespaces for remote repositories via upload-pack and receive-pack Jamey Sharp
2011-06-07 23:04 ` [PATCHv8 4/4] Add documentation for ref namespaces Jamey Sharp
2011-06-08 15:19   ` Marc Branchaud
2011-06-15 11:18 ` Painless namespaces design Jiang Xin
2011-06-15 14:00   ` Shawn Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110608014001.GA1800@leaf \
    --to=josh@joshtriplett.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=bert.wesarg@googlemail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jamey@minilop.net \
    --cc=jnareb@gmail.com \
    --cc=peff@peff.net \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).