From: Jeff King <peff@peff.net>
To: Andi Kleen <andi@firstfloor.org>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/2] Remove noreturn function pointers in usage.c
Date: Thu, 9 Jun 2011 01:52:24 -0400 [thread overview]
Message-ID: <20110609055224.GA27780@sigill.intra.peff.net> (raw)
In-Reply-To: <20110609045915.GA15448@one.firstfloor.org>
On Thu, Jun 09, 2011 at 06:59:15AM +0200, Andi Kleen wrote:
> > - Potential impact to people who do not use Gcc 4.6 with profile feedback
> > is not explained away well, except for "Doesn't seem to make any
> > difference."
>
> I merely went by "there are no new warnings" (I assume that's the main
> motivation)
On your compiler and settings, perhaps. With your patch I get:
usage.c: In function ‘die’:
usage.c:70:1: error: ‘noreturn’ function does return [-Werror]
And rightfully so:
void NORETURN die(const char *err, ...)
{
va_list params;
va_start(params, err);
die_routine(err, params);
va_end(params);
}
You've stripped the NORETURN from die_routine, so of course it looks like we
end up returning.
This is with:
$ gcc --version | head -n 1
gcc (Debian 4.6.0-11) 4.6.1 20110604 (prerelease)
-Peff
next prev parent reply other threads:[~2011-06-09 5:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 21:43 [PATCH 1/2] Remove noreturn function pointers in usage.c Andi Kleen
2011-06-08 21:43 ` [PATCH 2/2] Add profile feedback build to git Andi Kleen
2011-06-09 0:36 ` [PATCH 1/2] Remove noreturn function pointers in usage.c Junio C Hamano
2011-06-09 4:59 ` Andi Kleen
2011-06-09 5:52 ` Jeff King [this message]
2011-06-09 6:31 ` Andi Kleen
2011-06-09 21:13 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609055224.GA27780@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).