"libify part of reset" mini-series (Re: What's cooking in git.git (Jun 2011, #02; Sat, 11))

[Jonathan Nieder <jrnieder@gmail.com>]

Hi,

Ramkumar Ramachandra wrote:

> Have you seen my "libify reset" patch [1]?  I thought it was an easy candidate.

I don't think it is one, personally.  While it is good to get feedback
on such things early, that patch exposes some functions without making
the API much clearer and without any users to explain how they work in
practice.  I think it is best to let such patches cook in a private
branch until there is some obvious benefit to including them in git.

That benefit doesn't necessarily have to be new code using it --- it
could be increased clarity, faster compile times, decreasing the delta
with libgit2 so later fixes can be ported between the two more easily,
anything.  Though in this case, I'm guessing the motivation from your
end is the code that uses it, so that's an obvious choice.

I'd suggest sending it again for inclusion when the code that uses it
is ready, or for review whenever you have questions that the list can
answer.