From: Johan Herland <johan@herland.net>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Yann Dirson <ydirson@free.fr>
Subject: Re: [PATCH 1/6] Bring notes.c template handling in line with commit.c.
Date: Mon, 20 Jun 2011 09:41:54 +0200 [thread overview]
Message-ID: <201106200941.54883.johan@herland.net> (raw)
In-Reply-To: <7vpqm9e8rn.fsf@alter.siamese.dyndns.org>
On Monday 20 June 2011, Junio C Hamano wrote:
> Johan Herland <johan@herland.net> writes:
> > On Saturday 18 June 2011, Yann Dirson wrote:
> >> Signed-off-by: Yann Dirson <ydirson@free.fr>
> >
> > Please mention in the commit message that the commit merely replaces
> > write_or_die()/int fd with the corresponding stdio functionality, and
> > that there is no (intended) change in behavior. It was not apparent
> > from your commit message that you had not made any other changes.
> >
> > Otherwise the patch looks OK.
>
> I had an impression that you would lose a lot of error checking, unless
> you are careful, if you go from write_or_die() to stdio.
Yeah, write_or_die() dies on failure, while with fwrite/fprintf I guess one
needs to check the return value, and handle errors accordingly.
An alternative solution would be to drop this patch, and instead use
strbuf_addf() to get the format printing functionality needed in PATCH 3/6.
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
next prev parent reply other threads:[~2011-06-20 7:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 7:09 Commit notes workflow Yann Dirson
2011-06-14 10:15 ` Johan Herland
[not found] ` <f81891b81d39.4df76a5c@bertin.fr>
2011-06-14 14:41 ` Johan Herland
2011-06-15 9:20 ` ydirson
2011-06-15 9:37 ` Johan Herland
2011-06-15 9:57 ` ydirson
2011-06-15 10:53 ` Johan Herland
2011-06-18 21:06 ` [PATCH 0/6] Small notes usability improvements Yann Dirson
2011-06-18 21:06 ` [PATCH 1/6] Bring notes.c template handling in line with commit.c Yann Dirson
2011-06-19 21:23 ` Johan Herland
2011-06-19 22:50 ` Junio C Hamano
2011-06-20 7:41 ` Johan Herland [this message]
2011-06-20 18:48 ` Yann Dirson
2011-06-21 19:39 ` Yann Dirson
2011-06-18 21:06 ` [PATCH 2/6] Factorize shortening of notes refname for display Yann Dirson
2011-06-19 21:25 ` Johan Herland
2011-06-19 22:51 ` Junio C Hamano
2011-06-20 18:49 ` Yann Dirson
2011-06-18 21:06 ` [PATCH 3/6] Include name of notes ref in template when creating/editing notes Yann Dirson
2011-06-18 21:06 ` [PATCH 4/6] Allow "git notes merge" to use refs/remote-notes/ as a source Yann Dirson
2011-06-19 21:45 ` Johan Herland
2011-06-18 21:06 ` [PATCH 5/6] Assume a note ref starting with refs must not be prepended refs/notes/ Yann Dirson
2011-06-18 21:06 ` [PATCH 6/6] RFC - Notes merge: die when asked to merge a non-existent ref Yann Dirson
2011-06-19 22:03 ` Johan Herland
2011-06-20 7:16 ` Jeff King
2011-06-20 7:29 ` Johan Herland
2011-06-19 22:06 ` [PATCH 0/6] Small notes usability improvements Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106200941.54883.johan@herland.net \
--to=johan@herland.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ydirson@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).