From: Andi Kleen <andi@firstfloor.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Andi Kleen <andi@firstfloor.org>,
git@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/3] Add a lot of dummy returns to avoid warnings with NO_NORETURN
Date: Tue, 21 Jun 2011 00:00:27 +0200 [thread overview]
Message-ID: <20110620220027.GD32765@one.firstfloor.org> (raw)
In-Reply-To: <7vk4cgb24p.fsf@alter.siamese.dyndns.org>
> I would need to clarify with s/introduce noise/introduce more noise/; the
> existing codebase is not noise-free.
>
> But I do not see much point in making things worse, only to squelch
> "reaches end of non void function" warnings that will be given under the
> NO_NORETURN workaround configuration.
Can you please give specific guidance what I should do to make
the patchkit acceptable?
Current options are:
1) use original minimal patchkit (which had two warnings or so)
1b) use original minimal patchkit with warnings fixed
2) use global patch proposal for NO_NORETURN (= lots of warnings)
2b) use patch proposal + additional patch to fix warnings (posted here)
3) something I missed.
Which one do you prefer? If 3 I would prefer specific guidance.
Thanks,
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2011-06-20 22:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-19 1:07 [PATCH 1/3] Add option to disable NORETURN Andi Kleen
2011-06-19 1:07 ` [PATCH 2/3] Add a lot of dummy returns to avoid warnings with NO_NORETURN Andi Kleen
2011-06-20 21:17 ` Junio C Hamano
2011-06-20 21:30 ` Andi Kleen
2011-06-20 21:59 ` Junio C Hamano
2011-06-20 22:03 ` Andi Kleen
2011-06-20 22:31 ` Jonathan Nieder
2011-06-20 22:37 ` Andi Kleen
2011-06-20 22:46 ` Jonathan Nieder
2011-06-20 22:48 ` Jonathan Nieder
2011-06-21 0:24 ` Andi Kleen
2011-06-21 5:00 ` Jonathan Nieder
2011-06-20 23:26 ` Junio C Hamano
2011-06-21 0:17 ` Andi Kleen
2011-06-20 21:53 ` Junio C Hamano
2011-06-20 22:00 ` Andi Kleen [this message]
2011-06-20 22:30 ` Junio C Hamano
2011-06-20 22:33 ` Andi Kleen
2011-06-21 4:11 ` Junio C Hamano
2011-06-19 1:07 ` [PATCH 3/3] Add profile feedback build to git v2 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110620220027.GD32765@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).