* [PATCH] gitweb: 'pickaxe' feature requires 'search' enabled
@ 2011-06-20 21:40 Jakub Narebski
2011-06-21 6:41 ` [PATCH (amend)] gitweb: 'pickaxe' and 'grep' features requires 'search' to be enabled Jakub Narebski
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Narebski @ 2011-06-20 21:40 UTC (permalink / raw)
To: git
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
This is something I noticed when working on improving gitweb search.
gitweb/gitweb.perl | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index c9e6426..1a59781 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -342,6 +342,7 @@ our %feature = (
# Enable the pickaxe search, which will list the commits that modified
# a given string in a file. This can be practical and quite faster
# alternative to 'blame', but still potentially CPU-intensive.
+ # Note that you need to have 'search' feature enabled too.
# To enable system wide have in $GITWEB_CONFIG
# $feature{'pickaxe'}{'default'} = [1];
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH (amend)] gitweb: 'pickaxe' and 'grep' features requires 'search' to be enabled
2011-06-20 21:40 [PATCH] gitweb: 'pickaxe' feature requires 'search' enabled Jakub Narebski
@ 2011-06-21 6:41 ` Jakub Narebski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Narebski @ 2011-06-21 6:41 UTC (permalink / raw)
To: git
Both 'pickaxe' (searching changes) and 'grep' (searching files)
require basic 'search' feature to be enabled to work. Enabling
e.g. only 'pickaxe' won't work.
Add a comment about this.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
I'm sorry, I forgot that this issue applies to 'grep' feature too.
gitweb/gitweb.perl | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index c9e6426..63af8d4 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -328,6 +328,7 @@ our %feature = (
# Enable grep search, which will list the files in currently selected
# tree containing the given string. Enabled by default. This can be
# potentially CPU-intensive, of course.
+ # Note that you need to have 'search' feature enabled too.
# To enable system wide have in $GITWEB_CONFIG
# $feature{'grep'}{'default'} = [1];
@@ -342,6 +343,7 @@ our %feature = (
# Enable the pickaxe search, which will list the commits that modified
# a given string in a file. This can be practical and quite faster
# alternative to 'blame', but still potentially CPU-intensive.
+ # Note that you need to have 'search' feature enabled too.
# To enable system wide have in $GITWEB_CONFIG
# $feature{'pickaxe'}{'default'} = [1];
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-21 6:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-20 21:40 [PATCH] gitweb: 'pickaxe' feature requires 'search' enabled Jakub Narebski
2011-06-21 6:41 ` [PATCH (amend)] gitweb: 'pickaxe' and 'grep' features requires 'search' to be enabled Jakub Narebski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).