From: Jakub Narebski <jnareb@gmail.com>
To: Gurjeet Singh <singh.gurjeet@gmail.com>
Cc: git@vger.kernel.org, Eric Wong <normalperson@yhbt.net>
Subject: Re: Having some problem with instaweb
Date: Thu, 23 Jun 2011 21:29:21 +0200 [thread overview]
Message-ID: <201106232129.22137.jnareb@gmail.com> (raw)
In-Reply-To: <BANLkTinvSt9xGNSRKLGucsRKoChMfs_b9w@mail.gmail.com>
On Thu, 23 Jun 2011, Gurjeet Singh wrote:
> On Thu, Jun 23, 2011 at 4:23 AM, Jakub Narebski <jnareb@gmail.com> wrote:
>> Gurjeet Singh <singh.gurjeet@gmail.com> writes:
>>
>>> I am on Linux Mint 10 and I tried the following command:
>>>
>>> $ git instaweb -d apache2 -p 1234 --start
>>> Syntax error on line 1 of /mnt/storage/gurjeet/.git/gitweb/httpd.conf:
>>> Invalid command 'server.document-root', perhaps misspelled or defined
>>> by a module not included in the server configuration
>>> Could not execute http daemon apache2 -f.
>>
>> Hmmm... it looks like starts apache2, but generates config file
>> (httpd.conf) for lighttpd instead.
>>
>> Ahh... actually you started apache2, but didn't generate configuration
>> file for it, so git-instaweb re-uses previous config file... which by
>> default is lighttpd:
>>
>> start, --start
>> Start the httpd instance and exit. This does not generate any of the
>> configuration files for spawning a new instance.
>
> Now that's very unintuitive.... I am the impatient kind, and didn't
> read the whole paragraph. I assumed --start would just start the
> webserver (maybe run in daemon mode).
I'm working on it... actually the patch series is ready to send; it will
be sent as a reply to this email.
I just hope that it wouldn't be lost being deeper in thread...
>>> /mnt/storage/gurjeet/ is my $HOME.
>>
>> Nb. it doesn't mater where $HOME is, but where is git repository you
>> were in when calling git-instaweb.
>
> Got it. I have some files of my home directory in a Git repository, so
> $HOME is where the repository is.
>
> I have quite a few development related Git repositories under
> $HOME/dev/ and instaweb shows all of them on the first page (with
> description etc). IOW, is it supposed to recurse down all directories
> to look for .git/ directories?
>
> .git
> dev/EDB-ADVISORS/.git
> dev/EDBAS/.git
> dev/PCS/.git
> dev/PEM/.git
> dev/PGAGENT/.git
> dev/POSTGRES/.git
> dev/SERVICESTOOLS/.git
> dev/SLONY/.git
>
> Is this expected?
It is expected behavior.
It is consequence of the fact that the default gitweb mode is to search
for repositories recursively starting from given root; git-instaweb set
this $projectsroot to the one directory up from $GIT_DIR. Alternate
solution would be for git-instaweb to generate projects list file for
gitweb with only single repository listed...
Nevertheless usually you don't have repositories inside of working
directory of other repositories. There was even idea floated to deprecate
such support, but it didn't gained traction.
One expected exception is when you use _submodules_; in this case you
would probably want to see both supermodule and submodules (subrepositories).
That is why I think that current git-instaweb behavior has sense.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2011-06-23 19:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 1:06 Having some problem with instaweb Gurjeet Singh
2011-06-23 8:23 ` Jakub Narebski
2011-06-23 11:48 ` Gurjeet Singh
2011-06-23 19:29 ` Jakub Narebski [this message]
2011-06-23 19:50 ` [PATCH 0/4] git-instaweb: Improving handling of --start/--restart Jakub Narebski
2011-06-23 19:55 ` [PATCH 1/4] git-instaweb: Extract configuring web server into configure_httpd Jakub Narebski
2011-06-23 19:56 ` [PATCH 2/4] git-instaweb: Use $conf, not $fqgitdir/gitweb/httpd.conf Jakub Narebski
2011-06-23 20:59 ` [PATCH 3/4] git-instaweb: Move all actions at the end of script Jakub Narebski
2011-06-23 21:01 ` [PATCH 4/4] git-instaweb: Check that correct config file exists for (re)start Jakub Narebski
2011-06-28 3:22 ` [PATCH 0/4] git-instaweb: Improving handling of --start/--restart Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106232129.22137.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=singh.gurjeet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).