From: Greg Price <price@MIT.EDU>
To: Phil Hord <hordp@cisco.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 6/6] rebase --rewrite-refs: tests
Date: Tue, 28 Jun 2011 07:22:01 -0400 [thread overview]
Message-ID: <20110628112200.GX5771@dr-wily.mit.edu> (raw)
In-Reply-To: <4E08AAAE.5020604@cisco.com>
On Mon, Jun 27, 2011 at 12:07:10PM -0400, Phil Hord wrote:
> On 01/24/2010 09:28 PM, Greg Price wrote:
> > +test_expect_success setup '
> > + test_commit A &&
> > + git branch topic &&
> > + test_commit B &&
> > + git checkout topic &&
> > + test_commit C &&
> > + git branch part1 &&
> > + test_commit D
> > + git branch part2 &&
> > + test_commit E
> > +'
>
> I think there is a missing "&&" at the end of "test_commit D". But it's
> possible I just don't understand the test machinery enough to know this
> is normal. Can you explain to me the difference in that case?
Nope, that's just a mistake -- it means that if "test_commit D" were
to somehow fail, we'd move on as if nothing was wrong. Fixed, thanks.
Greg
next prev parent reply other threads:[~2011-06-28 11:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 0:16 [PATCH 0/6] rebase: command "ref" and options --rewrite-{refs,heads,tags} Greg Price
2009-10-10 2:52 ` [PATCH 1/6] rebase -i: Add the "ref" command Greg Price
2011-06-27 18:46 ` Junio C Hamano
2011-06-28 11:15 ` Greg Price
2009-11-18 23:22 ` [PATCH 2/6] pretty: Add %D for script-friendly decoration Greg Price
2011-06-27 19:07 ` Junio C Hamano
2009-11-18 23:51 ` [PATCH 4/6] rebase: --rewrite-{refs,heads,tags} to pull refs along with branch Greg Price
2011-06-27 16:11 ` Phil Hord
2011-06-28 11:19 ` Greg Price
2010-01-07 23:08 ` [PATCH 3/6] for-each-ref: --stdin to match specified refs against pattern Greg Price
2010-01-25 2:26 ` [PATCH 5/6] t/lib-rebase.sh: pass through ref commands Greg Price
2010-01-25 2:28 ` [PATCH 6/6] rebase --rewrite-refs: tests Greg Price
2011-06-27 16:07 ` Phil Hord
2011-06-28 11:22 ` Greg Price [this message]
2011-06-27 21:02 ` Junio C Hamano
2011-06-28 11:20 ` Greg Price
2011-06-27 18:36 ` [PATCH 0/6] rebase: command "ref" and options --rewrite-{refs,heads,tags} Junio C Hamano
[not found] ` <BANLkTinDFYsw7-N=_Ex8i42So_0LzVAWvA@mail.gmail.com>
2011-06-28 10:47 ` Fwd: " Greg Price
2011-06-28 13:17 ` Greg Price
2011-06-30 4:25 ` Ramkumar Ramachandra
2011-08-03 13:32 ` Fwd: " Sverre Rabbelier
2011-08-03 22:31 ` Greg Price
2011-06-27 21:23 ` Junio C Hamano
[not found] ` <BANLkTi=Akib+7R7D2GEwV8dOTQ1vsqgfxA@mail.gmail.com>
2011-06-28 10:56 ` Fwd: " Greg Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110628112200.GX5771@dr-wily.mit.edu \
--to=price@mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hordp@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).