From: Jeff King <peff@peff.net>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] rebase: do not print lots of usage hints after an obvious error message
Date: Tue, 28 Jun 2011 11:54:34 -0400 [thread overview]
Message-ID: <20110628155434.GA3747@sigill.intra.peff.net> (raw)
In-Reply-To: <4E09CD16.2040800@viscovery.net>
On Tue, Jun 28, 2011 at 02:46:14PM +0200, Johannes Sixt wrote:
> The error message was introduced recently by 4ac5356c (rebase: give a
> better error message for bogus branch, 2011-01-27), and the result was
> acceptable because the usage text was just two lines. But 45e2acf3
> (rebase: define options in OPTIONS_SPEC, 2011-02-28) made things worse
> because the usage text is now 35 lines.
>
> Just drop the usage information because it does not add value to the
> error message.
Acked-by: Jeff King <peff@peff.net>
A git-sh-setup function to print just the summary bit of the usage would
restore the original behavior, but I agree it's not really adding
anything.
-Peff
prev parent reply other threads:[~2011-06-28 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 12:46 [PATCH] rebase: do not print lots of usage hints after an obvious error message Johannes Sixt
2011-06-28 15:54 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110628155434.GA3747@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).