git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder@ira.uka.de>
To: <git@vger.kernel.org>
Subject: [BUG] gitk update/reload doesn't refresh notes
Date: Mon, 4 Jul 2011 17:36:00 +0200	[thread overview]
Message-ID: <20110704153600.GF1982@goldbirke> (raw)

Hi,


I would expect that when I start gitk with '--show-notes' option and
press update or reload, then it updates not just the commits, but the
notes shown in the log/diff window, too.  However, as shown below,
this is not the case.

  notes_vs_gitk$ git init
  Initialized empty Git repository in
  /home/szeder/tmp/git/notes_vs_gitk/.git/
  notes_vs_gitk (master)$ echo 1 >foo
  notes_vs_gitk (master)$ git add foo
  notes_vs_gitk (master)$ git commit -m First. foo
  [master (root-commit) 88dbd6b] First.
   1 files changed, 1 insertions(+), 0 deletions(-)
   create mode 100644 foo
  notes_vs_gitk (master)$ gitk --show-notes master &
  [1] 15673
  notes_vs_gitk (master)$ git notes add -m "Note,
  that these notes will not appear in gitk without restarting it"
  notes_vs_gitk (master)$ git log
  commit 88dbd6bf8f1e3e4fc94d1da5e73754c7d2f0f244
  Author: SZEDER Gábor <szeder@ira.uka.de>
  Date:   2011-07-04 17:18:28 +0200
  
      First.
  
  Notes:
      Note, that these notes will not appear in gitk without restarting it
  
  # Press F5 in gitk for update.
  # Nope, notes are not shown.
  # Press ctrl-F5 in gitk for reload.
  # Notes are still not shown.
  
  notes_vs_gitk (master)$ kill %1
  [1]+  Terminated              gitk --show-notes master
  notes_vs_gitk (master)$ gitk --show-notes master &
  [1] 15826
  
  # Notes are shown, finally.

  notes_vs_gitk (master)$ git notes remove 
  Removing note for object HEAD

  # Press F5/ctrl-F5 in gitk.
  # The removed notes are still there.


Best,
Gábor

                 reply	other threads:[~2011-07-04 15:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110704153600.GF1982@goldbirke \
    --to=szeder@ira.uka.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).