From: Jeff King <peff@peff.net>
To: Erik Faye-Lund <kusmabite@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC 3/3] upload-archive: use start_command instead of fork
Date: Thu, 7 Jul 2011 18:27:26 -0400 [thread overview]
Message-ID: <20110707222726.GA23424@sigill.intra.peff.net> (raw)
In-Reply-To: <CABPQNSYZqpfGwgQXqk4YFBXhSHTen1w7m2hwaF7YDsZmsaYY5Q@mail.gmail.com>
On Fri, Jul 08, 2011 at 12:25:00AM +0200, Erik Faye-Lund wrote:
> On Thu, Jul 7, 2011 at 9:15 PM, Jeff King <peff@peff.net> wrote:
> > On Thu, Jul 07, 2011 at 01:43:09PM +0200, Erik Faye-Lund wrote:
> >
> >> The POSIX-function fork is not supported on Windows. Use our
> >> start_command API instead.
> >
> > Is start_command the right solution? From my reading, the fork is
> > actually because we want to set up a sideband multiplexer. Should we not
> > just be using start_async() to start a thread, as we do in receive-pack?
>
> I considered that, but discarded it because I figured it required me
> to plug through a file descriptor all the way through the code. But
> perhaps I was wrong, and dup2 will make that job a lot easier?
Yeah, exactly. The current code is already using dup2 in the same way.
-Peff
next prev parent reply other threads:[~2011-07-07 22:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 11:43 [PATCH/RFC 0/3] port upload-archive to windows Erik Faye-Lund
2011-07-07 11:43 ` [PATCH/RFC 1/3] compat/win32/sys/poll.c: upgrade from upstream Erik Faye-Lund
2011-07-07 11:43 ` [PATCH/RFC 2/3] mingw: fix compilation of poll-emulation Erik Faye-Lund
2011-07-07 11:43 ` [PATCH/RFC 3/3] upload-archive: use start_command instead of fork Erik Faye-Lund
2011-07-07 18:21 ` Johannes Sixt
2011-07-07 18:39 ` Erik Faye-Lund
2011-07-07 19:15 ` Jeff King
2011-07-07 22:25 ` Erik Faye-Lund
2011-07-07 22:27 ` Jeff King [this message]
2011-07-07 22:37 ` Erik Faye-Lund
2011-07-07 22:44 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110707222726.GA23424@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).