From: Jeff King <peff@peff.net>
To: Chris Packham <judge.packham@gmail.com>
Cc: GIT <git@vger.kernel.org>
Subject: Re: Redoing a merge for a particular file
Date: Thu, 7 Jul 2011 18:41:15 -0400 [thread overview]
Message-ID: <20110707224114.GA23273@sigill.intra.peff.net> (raw)
In-Reply-To: <CAFOYHZCFetkokgtn4z0O3nPTEy6GCTEcN0Pzc8ce-joqMzZM1Q@mail.gmail.com>
On Fri, Jul 08, 2011 at 10:24:10AM +1200, Chris Packham wrote:
> I'm in the middle of merging to branches and I've screwed up my manual
> merge, I've also got rerere enabled and I can't seem to get back into
> a state to trigger git mergetool again.
>
> $ git merge topic
> ...
> $ git mergetool
> $ make
> error: foo.c ... oops screwed up that merge.
>
> The merge wasn't too painful so I don't mind starting again.
>
> $ git reset --hard HEAD^
> HEAD is now at 59c6097 ...
> $ git merge topic
> Auto-merging foo.c
> CONFLICT (content): Merge conflict in foo.c
> Auto-merging bar.c
> CONFLICT (content): bar.c
> Auto-merging otherfile1.c
> Auto-merging otherfile2.c
> Auto-merging otherfile3.c
> Resolved 'foo.c' using previous resolution.
> Resolved 'bar.c' using previous resolution.
> Automatic merge failed; fix conflicts and then commit the result.
> $ git mergetool
> No files need merging
>
> So rerere has remembered the bad resolution of foo.c. But even if I
> run 'git rerere clear' and repeat the above sequence I get the same
> result.
I think you actually want "rerere forget". Like:
$ git reset --hard HEAD^
$ git merge topic
$ git rerere forget foo.c
Although it is slightly more complicated if you have set
rerere.autoupdate, since it will have cleared the index of any notion
that the path was conflicted. In that case you can then follow the
"rerere forget" with:
$ git reset --hard
$ git merge topic
to retry again.
But it doesn't look like you have autoupdate on, from the output above
(it would say "Staged 'foo.c'" instead of "Resolved 'foo.c", I believe).
> I seem to remember something like this coming up before.
> Wasn't there an option added to checkout to allow us to recreate the
> pre-merge state?
>
> $ git checkout --merge foo.c
> $ git mergetool
> No files need merging
If you have rerere.autoupdate on, then it will have updated the index,
and the path will not appear unmerged. You can use the trick above to
get past it.
If you aren't using rerere.autoupdate (and haven't updated the index
yourself), you shouldn't even need the "git checkout --merge" line. It
just updates the working tree with the conflicted content, but mergetool
will operate directly on the original versions contained in the index,
anyway.
> $ git status
> # On branch master
> # Your branch is behind 'origin/master' by 1 commit, and can be
> fast-forwarded.
> #
> # Changes to be committed:
> ....
> # Unmerged paths:
> # (use "git add/rm <file>..." as appropriate to mark resolution)
> #
> # both modified: foo.c
> #
>
> foo.c now does have conflict markers in it so I think it's crying out
> to be re-merged I just can't convince mergetool to do it. Am I doing
> something wrong?
Hmm. That does seem like "git checkout --merge" did the right thing, but
that "mergetool" is wrong for not accepting it (it _should_ just be
looking at what's in the index to find unmerged paths).
Ahh. It is probably the fault of bb0a484 (mergetool: Skip autoresolved
paths, 2010-08-17), which checks with rerere to avoid resolved paths. So
I think:
$ git rerere forget foo.c
$ git mergetool
would do what you want.
-Peff
next prev parent reply other threads:[~2011-07-07 22:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 22:24 Redoing a merge for a particular file Chris Packham
2011-07-07 22:41 ` Jeff King [this message]
2011-07-07 23:31 ` Chris Packham
2011-07-08 0:37 ` Junio C Hamano
2011-07-08 0:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110707224114.GA23273@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=judge.packham@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).