From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
"Neal Kreitzinger" <neal@rsss.com>,
git@vger.kernel.org
Subject: Re: git-archive and tar options
Date: Thu, 14 Jul 2011 17:25:02 -0400 [thread overview]
Message-ID: <20110714212502.GA29848@sigill.intra.peff.net> (raw)
In-Reply-To: <7vei1s36bl.fsf@alter.siamese.dyndns.org>
On Thu, Jul 14, 2011 at 02:23:10PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Couldn't you also do:
> >
> > git archive --prefix=$prefix HEAD:$subdir >my.tar
> >
> > ? I guess that loses the pax header with the commit sha1 in it, though,
> > because you are feeding a straight tree instead of a commit.
> >
> > We didn't when git-archive was written, but these days we have
> > get_sha1_with_context to remember incidental things about an object we
> > look up. It should perhaps remember the commit (if any) we used to reach
> > a treeish, and then the above command line could still insert the pax
> > header.
>
> Why?
>
> The tree you are writing out that way look very different from what is
> recorded in the commit object. What's the point of introducing confusion
> by allowing many tarballs with different contents written from the same
> commits with such tweaks all labelled with the same pax header?
See my later message. I think it depends on how the embedded id is used.
Is it to say "this represents the tree of this git commit"? Or is it to
help people who later have a tarball and have no clue which commit it
might have come from?
I don't have a strong opinion either way. I've never used this feature
at all.
-Peff
next prev parent reply other threads:[~2011-07-14 21:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 23:34 git-archive and tar options Neal Kreitzinger
2011-07-14 1:56 ` Jeff King
2011-07-14 17:16 ` René Scharfe
2011-07-14 17:27 ` Jeff King
2011-07-14 17:45 ` René Scharfe
2011-07-14 18:18 ` Jeff King
2011-07-14 19:12 ` Jakub Narebski
2011-07-14 21:23 ` Junio C Hamano
2011-07-14 21:25 ` Jeff King [this message]
2011-07-14 23:30 ` Junio C Hamano
2011-07-15 20:59 ` René Scharfe
2011-07-18 19:31 ` Neal Kreitzinger
2011-07-18 20:50 ` René Scharfe
2011-07-14 21:38 ` Jakub Narebski
2011-07-18 18:13 ` Neal Kreitzinger
2011-07-18 20:50 ` René Scharfe
2011-07-19 0:12 ` Neal Kreitzinger
2011-07-19 17:56 ` René Scharfe
2011-07-21 2:13 ` Neal Kreitzinger
2011-07-21 16:59 ` Neal Kreitzinger
2011-07-14 17:48 ` Andreas Schwab
2011-07-19 20:10 ` Sylvain Rabot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110714212502.GA29848@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=neal@rsss.com \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).