From: Jeff King <peff@peff.net>
To: Peter Simons <simons@cryp.to>
Cc: git@vger.kernel.org
Subject: Re: [BUG] git-am and git-submodule rely on $PATH to find perl
Date: Fri, 22 Jul 2011 16:40:18 -0600 [thread overview]
Message-ID: <20110722224017.GC19620@sigill.intra.peff.net> (raw)
In-Reply-To: <87fwm0inqr.fsf@write-only.cryp.to>
On Thu, Jul 21, 2011 at 12:35:56AM +0200, Peter Simons wrote:
> Both scripts run perl without any path, i.e. they don't use the
> $PERL_PATH that was passed at build time.
This isn't exactly a bug. The rule we usually follow in git is that you
can use "perl" in the PATH when you are doing simple awk-like things
that any version of perl should do. But you must use PERL_PATH for
#!-lines (because we can't do PATH lookup there), or for any non-trivial
script.
That being said, I don't see any downside to using PERL_PATH. The
Makefile tweaks would be pretty minimal. Want to work up a patch?
-Peff
prev parent reply other threads:[~2011-07-22 22:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 22:35 [BUG] git-am and git-submodule rely on $PATH to find perl Peter Simons
2011-07-22 22:40 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110722224017.GC19620@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=simons@cryp.to \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).