* Help using git I'm review process
@ 2011-07-24 12:12 Mathew Benson
2011-07-24 12:16 ` Thomas Adam
0 siblings, 1 reply; 9+ messages in thread
From: Mathew Benson @ 2011-07-24 12:12 UTC (permalink / raw)
To: git@vger.kernel.org
I'm planning to use git for a work project, which requires tight control of the peer review process. In previous jobs, the peer review was a tedious manual process of creating PDF files, writing comments in spreadsheets, and copying comments to the CM system. I want to use technology to my best advantage.
Once a developer has completed all his changes in his development branch, what's the best way to get those files to the reviewers, without requiring the author to stop work? First, I think I should create a tag in the developer branch. Each developer has a local repository, and my review tool writes files directly in the work area. Can they just fetch, checkout a tag (don't know how to do that), commit changes, and push it back to the central repository? Is there a better workflow?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Help using git I'm review process
2011-07-24 12:12 Help using git I'm review process Mathew Benson
@ 2011-07-24 12:16 ` Thomas Adam
2011-07-24 12:42 ` Mathew Benson
2011-07-24 14:37 ` Jens Lehmann
0 siblings, 2 replies; 9+ messages in thread
From: Thomas Adam @ 2011-07-24 12:16 UTC (permalink / raw)
To: Mathew Benson; +Cc: git@vger.kernel.org
On 24 July 2011 13:12, Mathew Benson <mathew.benson@gmail.com> wrote:
> I'm planning to use git for a work project, which requires tight control of the peer review process. In previous jobs, the peer review was a tedious manual process of creating PDF files, writing comments in spreadsheets, and copying comments to the CM system. I want to use technology to my best advantage.
>
> Once a developer has completed all his changes in his development branch, what's the best way to get those files to the reviewers, without requiring the author to stop work? First, I think I should create a tag in the developer branch. Each developer has a local repository, and my review tool writes files directly in the work area. Can they just fetch, checkout a tag (don't know how to do that), commit changes, and push it back to the central repository? Is there a better workflow?--
This is what Gerrit is useful for.
-- Thomas Adam
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Help using git I'm review process
2011-07-24 12:16 ` Thomas Adam
@ 2011-07-24 12:42 ` Mathew Benson
2011-07-24 12:53 ` Thomas Adam
2011-07-24 14:37 ` Jens Lehmann
1 sibling, 1 reply; 9+ messages in thread
From: Mathew Benson @ 2011-07-24 12:42 UTC (permalink / raw)
To: Thomas Adam; +Cc: git@vger.kernel.org
I found that in my research but my IT "department" recommended a tool they're already using. I'll push Gerrit again. Is there an online demo?
Sent from my iPad
On Jul 24, 2011, at 7:16 AM, Thomas Adam <thomas@xteddy.org> wrote:
> On 24 July 2011 13:12, Mathew Benson <mathew.benson@gmail.com> wrote:
>> I'm planning to use git for a work project, which requires tight control of the peer review process. In previous jobs, the peer review was a tedious manual process of creating PDF files, writing comments in spreadsheets, and copying comments to the CM system. I want to use technology to my best advantage.
>>
>> Once a developer has completed all his changes in his development branch, what's the best way to get those files to the reviewers, without requiring the author to stop work? First, I think I should create a tag in the developer branch. Each developer has a local repository, and my review tool writes files directly in the work area. Can they just fetch, checkout a tag (don't know how to do that), commit changes, and push it back to the central repository? Is there a better workflow?--
>
> This is what Gerrit is useful for.
>
> -- Thomas Adam
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Help using git I'm review process
2011-07-24 12:16 ` Thomas Adam
2011-07-24 12:42 ` Mathew Benson
@ 2011-07-24 14:37 ` Jens Lehmann
2011-07-24 15:32 ` Mathew Benson
1 sibling, 1 reply; 9+ messages in thread
From: Jens Lehmann @ 2011-07-24 14:37 UTC (permalink / raw)
To: Thomas Adam; +Cc: Mathew Benson, git@vger.kernel.org
Am 24.07.2011 14:16, schrieb Thomas Adam:
> On 24 July 2011 13:12, Mathew Benson <mathew.benson@gmail.com> wrote:
>> I'm planning to use git for a work project, which requires tight control of the peer review process. In previous jobs, the peer review was a tedious manual process of creating PDF files, writing comments in spreadsheets, and copying comments to the CM system. I want to use technology to my best advantage.
>>
>> Once a developer has completed all his changes in his development branch, what's the best way to get those files to the reviewers, without requiring the author to stop work? First, I think I should create a tag in the developer branch. Each developer has a local repository, and my review tool writes files directly in the work area. Can they just fetch, checkout a tag (don't know how to do that), commit changes, and push it back to the central repository? Is there a better workflow?--
>
> This is what Gerrit is useful for.
Yes, Gerrit is a very sophisticated way to do that.
But you can also achieve a review process by just using git and email
too: Have each developer do each topic of his work on a separate feature
branch and send merge requests (e.g. per email) to the reviewer when he
is done. If the reviewer approves the changes, he merges that branch
(and deletes the remote topic branch, as that topic is now finished and
part of the history). If not, he requests improvements from the developer
who updates that branch and sends another review request when he is done.
We use this approach successfully at my dayjob.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Help using git I'm review process
2011-07-24 14:37 ` Jens Lehmann
@ 2011-07-24 15:32 ` Mathew Benson
0 siblings, 0 replies; 9+ messages in thread
From: Mathew Benson @ 2011-07-24 15:32 UTC (permalink / raw)
To: Jens Lehmann; +Cc: Thomas Adam, git@vger.kernel.org
Great. That confirms what I thought. Thanks.
On Jul 24, 2011, at 9:37 AM, Jens Lehmann <Jens.Lehmann@web.de> wrote:
> Am 24.07.2011 14:16, schrieb Thomas Adam:
>> On 24 July 2011 13:12, Mathew Benson <mathew.benson@gmail.com> wrote:
>>> I'm planning to use git for a work project, which requires tight control of the peer review process. In previous jobs, the peer review was a tedious manual process of creating PDF files, writing comments in spreadsheets, and copying comments to the CM system. I want to use technology to my best advantage.
>>>
>>> Once a developer has completed all his changes in his development branch, what's the best way to get those files to the reviewers, without requiring the author to stop work? First, I think I should create a tag in the developer branch. Each developer has a local repository, and my review tool writes files directly in the work area. Can they just fetch, checkout a tag (don't know how to do that), commit changes, and push it back to the central repository? Is there a better workflow?--
>>
>> This is what Gerrit is useful for.
>
> Yes, Gerrit is a very sophisticated way to do that.
>
> But you can also achieve a review process by just using git and email
> too: Have each developer do each topic of his work on a separate feature
> branch and send merge requests (e.g. per email) to the reviewer when he
> is done. If the reviewer approves the changes, he merges that branch
> (and deletes the remote topic branch, as that topic is now finished and
> part of the history). If not, he requests improvements from the developer
> who updates that branch and sends another review request when he is done.
> We use this approach successfully at my dayjob.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-07-24 16:03 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-24 12:12 Help using git I'm review process Mathew Benson
2011-07-24 12:16 ` Thomas Adam
2011-07-24 12:42 ` Mathew Benson
2011-07-24 12:53 ` Thomas Adam
[not found] ` <E394E5A1-8F0E-47E6-AE69-A974655B2D13@gmail.com>
2011-07-24 14:02 ` Fwd: " Thomas Adam
2011-07-24 14:19 ` Mathew Benson
2011-07-24 15:40 ` Fwd: " Magnus Bäck
2011-07-24 14:37 ` Jens Lehmann
2011-07-24 15:32 ` Mathew Benson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).