From: Clemens Buchacher <drizzd@aon.at>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Break down no-lstat() condition checks in verify_uptodate()
Date: Sat, 30 Jul 2011 18:22:59 +0200 [thread overview]
Message-ID: <20110730162258.GC7545@toss.lan> (raw)
In-Reply-To: <1311998105-6267-1-git-send-email-pclouds@gmail.com>
On Sat, Jul 30, 2011 at 10:55:05AM +0700, Nguyễn Thái Ngọc Duy wrote:
>
> + /*
> + * CE_VALID and CE_SKIP_WORKTREE cheat, we better check again
> + * if this entry is truely uptodate because this file may be
> + * overwritten.
> + */
s/truely/truly
> + if ((ce->ce_flags & CE_VALID) || ce_skip_worktree(ce))
> + ; /* keep checking */
> + else if (o->reset || ce_uptodate(ce))
> return 0;
Nice! Acked-by: Clemens Buchacher <drizzd@aon.at>
prev parent reply other threads:[~2011-07-30 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-30 3:55 [PATCH] Break down no-lstat() condition checks in verify_uptodate() Nguyễn Thái Ngọc Duy
2011-07-30 16:22 ` Clemens Buchacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110730162258.GC7545@toss.lan \
--to=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).