From: Christian Couder <chriscool@tuxfamily.org>
To: Jon Seymour <jon.seymour@gmail.com>
Cc: git@vger.kernel.org, j6t@kdbg.org, gitster@pobox.com, jnareb@gmail.com
Subject: Re: [PATCH 3/5] bisect: introduce --no-checkout[=<ref>] support into porcelain.
Date: Sat, 30 Jul 2011 16:34:32 +0200 [thread overview]
Message-ID: <201107301634.33710.chriscool@tuxfamily.org> (raw)
In-Reply-To: <1312014511-7157-4-git-send-email-jon.seymour@gmail.com>
On Saturday 30 July 2011 10:28:29 Jon Seymour wrote:
> diff --git a/git-bisect.sh b/git-bisect.sh
> index b2186a8..6c4e853 100755
> --- a/git-bisect.sh
> +++ b/git-bisect.sh
> @@ -3,7 +3,7 @@
> USAGE='[help|start|bad|good|skip|next|reset|visualize|replay|log|run]'
> LONG_USAGE='git bisect help
> print this long help message.
> -git bisect start [<bad> [<good>...]] [--] [<pathspec>...]
> +git bisect start [--no=checkout[=<ref>]] [<bad> [<good>...]] [--]
s/--no=checkout/--no-checkout/
> [<pathspec>...] reset bisect state and start bisection.
> git bisect bad [<rev>]
> mark <rev> a known-bad revision.
> @@ -34,6 +34,8 @@ require_work_tree
> _x40='[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]'
> _x40="$_x40$_x40$_x40$_x40$_x40$_x40$_x40$_x40"
>
> +BISECT_NOCHECKOUT=$(test -f "${GIT_DIR}/BISECT_NOCHECKOUT" && cat
> "${GIT_DIR}/BISECT_NOCHECKOUT")
Is there a reason you use "${GIT_DIR}" instead of "$GIT_DIR" that is used
everywhere else?
Thanks,
Christian.
next prev parent reply other threads:[~2011-07-30 14:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-30 8:28 [PATCH 0/5] bisect: Add support for a --no-checkout option Jon Seymour
2011-07-30 8:28 ` [PATCH 1/5] bisect: add tests to document expected behaviour in presence of broken trees Jon Seymour
2011-07-30 8:28 ` [PATCH 2/5] bisect: introduce support for --no-checkout=<ref> option Jon Seymour
2011-07-30 13:49 ` Christian Couder
2011-07-30 8:28 ` [PATCH 3/5] bisect: introduce --no-checkout[=<ref>] support into porcelain Jon Seymour
2011-07-30 14:34 ` Christian Couder [this message]
2011-07-30 17:00 ` Jon Seymour
2011-07-31 0:36 ` Christian Couder
2011-08-01 0:53 ` Junio C Hamano
2011-08-01 4:35 ` Christian Couder
2011-07-30 8:28 ` [PATCH 4/5] bisect: add tests for the --no-checkout option Jon Seymour
2011-07-30 8:28 ` [PATCH 5/5] bisect: add documentation for --no-checkout[=<ref>] option Jon Seymour
2011-07-30 8:30 ` [PATCH 0/5] bisect: Add support for a --no-checkout option Jon Seymour
2011-07-30 13:48 ` Christian Couder
2011-07-30 13:58 ` Jon Seymour
2011-07-30 14:19 ` Christian Couder
2011-08-01 1:00 ` Junio C Hamano
2011-08-01 4:42 ` Christian Couder
2011-08-01 5:27 ` Jon Seymour
2011-08-01 17:33 ` Junio C Hamano
2011-08-01 22:19 ` Jon Seymour
2011-08-01 23:33 ` Junio C Hamano
2011-08-02 1:15 ` Jon Seymour
2011-08-02 1:41 ` Jon Seymour
2011-08-02 17:53 ` Junio C Hamano
2011-08-02 21:27 ` Jon Seymour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107301634.33710.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jnareb@gmail.com \
--cc=jon.seymour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).