git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pete Wyckoff <pw@padd.com>
To: Luke Diamand <luke@diamand.org>
Cc: git@vger.kernel.org
Subject: [PATCHv2 3/4] git-p4: one test missing config git-p4.skipSubmitEditCheck
Date: Sun, 31 Jul 2011 09:45:38 -0400	[thread overview]
Message-ID: <20110731134538.GE6564@arf.padd.com> (raw)
In-Reply-To: <20110731134416.GB6564@arf.padd.com>

Add this missing line in one of the tests.  Otherwise, on fast
machines, the following git-p4 commit will complain that nobody
edited the submission message.

Signed-off-by: Pete Wyckoff <pw@padd.com>
Acked-by: Luke Diamand <luke@diamand.org>
---
 t/t9800-git-p4.sh |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/t/t9800-git-p4.sh b/t/t9800-git-p4.sh
index b7eda82..b304707 100755
--- a/t/t9800-git-p4.sh
+++ b/t/t9800-git-p4.sh
@@ -191,6 +191,7 @@ test_expect_success 'refuse to preserve users without perms' '
 	"$GITP4" clone --dest="$git" //depot &&
 	test_when_finished cleanup_git &&
 	cd "$git" &&
+	git config git-p4.skipSubmitEditCheck true &&
 	echo "username-noperms: a change by alice" >> file1 &&
 	git commit --author "Alice <alice@localhost>" -m "perms: a change by alice" file1 &&
 	! P4EDITOR=touch P4USER=bob P4PASSWD=secret "$GITP4" commit --preserve-user &&
-- 
1.7.5.4

  parent reply	other threads:[~2011-07-31 13:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-31  0:35 [PATCH 0/4] git-p4 test cleanup, commit time change Pete Wyckoff
2011-07-31  0:38 ` [PATCH 1/4] git-p4: use test_when_finished in tests Pete Wyckoff
2011-07-31  9:59   ` Luke Diamand
2011-07-31  0:39 ` [PATCH 2/4] git-p4: make tests work on p4d eval server Pete Wyckoff
2011-07-31  0:39 ` [PATCH 3/4] git-p4: one test missing config git-p4.skipSubmitEditCheck Pete Wyckoff
2011-07-31 10:01   ` Luke Diamand
2011-07-31  0:39 ` [PATCH 4/4] git-p4: commit time should be most recent p4 change time Pete Wyckoff
2011-07-31 10:14   ` Luke Diamand
2011-07-31  9:49 ` [PATCH 0/4] git-p4 test cleanup, commit time change Luke Diamand
2011-07-31 13:42   ` Pete Wyckoff
2011-07-31 16:01     ` Luke Diamand
2011-07-31 13:44 ` [PATCHv2 " Pete Wyckoff
2011-07-31 13:44   ` [PATCHv2 1/4] git-p4: use test_when_finished in tests Pete Wyckoff
2011-07-31 13:45   ` [PATCHv2 2/4] git-p4: add missing && in test Pete Wyckoff
2011-07-31 13:55     ` Luke Diamand
2011-07-31 13:45   ` Pete Wyckoff [this message]
2011-07-31 13:45   ` [PATCHv2 4/4] git-p4: commit time should be most recent p4 change time Pete Wyckoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110731134538.GE6564@arf.padd.com \
    --to=pw@padd.com \
    --cc=git@vger.kernel.org \
    --cc=luke@diamand.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).